You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR provides minimal updates to support the upcoming ex_cldr version 2.44.0 that itself is updated for CLDR 48.
The primary change - which needs review - is to the flag_exists?/1 function which relied upon all mapped territories having children. With the new data that is no longer a valid assumption. There may be a better workaround than contained in this PR.
This PR provides minimal updates to support the upcoming ex_cldr version 2.44.0 that itself is updated for CLDR 48.
The primary change - which needs review - is to the flag_exists?/1 function which relied upon all mapped territories having children. With the new data that is no longer a valid assumption. There may be a better workaround than contained in this PR.
The flag_exists?/1 function might benefit by a dedicated recursive function, but I don’t see that as a blocker, we can just leave that open for any contribution.
It looks like the CI is failing I’ll have a look at that tomorrow before I merge an release!
I think the CI issue is because I pushed the PR before I published the ex_cldr update. So should be ok when it's re-run. (I've published all the updates on my side for CLDR 48).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides minimal updates to support the upcoming
ex_cldrversion 2.44.0 that itself is updated for CLDR 48.The primary change - which needs review - is to the
flag_exists?/1function which relied upon all mapped territories having children. With the new data that is no longer a valid assumption. There may be a better workaround than contained in this PR.