Repository navigation
Pass the plugin portal's Qt6 check - #125
Merged
Merged
Conversation
The plugin portal's Qt6 check (a static scan) flagged the QGIS < 3.30/3.36 fallback branches in const.py. Use the scoped spellings it asks for (QgsWkbTypes.GeometryType.LineGeometry, QgsProcessing.SourceType.TypeVectorLine, QgsProcessingParameterNumber.Type.Double); they resolve to the same values on QGIS 3.22, so there is no behavior change. Claude-Session: https://claude.ai/code/session_017Nqnnwk4GAh8KymZVVDciM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage ? 59.40%
=======================================
Files ? 13
Lines ? 840
Branches ? 120
=======================================
Hits ? 499
Misses ? 311
Partials ? 30 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin portal's Qt6 check flagged 2.1.1 with 5 enum issues, all in the fallback branches of
src/const.pythat only run on QGIS older than 3.30/3.36:QgsWkbTypes.LineGeometry/PolygonGeometryQgsWkbTypes.GeometryType.LineGeometry/PolygonGeometryQgsProcessing.TypeVectorLine/TypeVectorPolygonQgsProcessing.SourceType.TypeVectorLine/TypeVectorPolygonQgsProcessingParameterNumber.DoubleQgsProcessingParameterNumber.Type.DoubleThese are the spellings the checker asks for. The check reads the code without running it, so it can't tell that these lines are version-gated; no Qt6 behavior was actually broken.
Verification
qgis/qgis:3.22(where this branch runs, since 3.22 has noQgis.GeometryType): the new spellings exist, equal the old aliases, andconst.pyimports cleanly.make test-all, 63 passed.https://claude.ai/code/session_017Nqnnwk4GAh8KymZVVDciM