Skip to content

Pass the plugin portal's Qt6 check - #125

Merged
elfpkck merged 2 commits into
mainfrom
fix/qt6-check-enums
Sep 26, 2026
Merged

elfpkck merged 2 commits into
mainfrom
fix/qt6-check-enums

Conversation

@elfpkck

@elfpkck elfpkck commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Summary

The plugin portal's Qt6 check flagged 2.1.1 with 5 enum issues, all in the fallback branches of src/const.py that only run on QGIS older than 3.30/3.36:

Line Before After
11-12 QgsWkbTypes.LineGeometry / PolygonGeometry QgsWkbTypes.GeometryType.LineGeometry / PolygonGeometry
22-23 QgsProcessing.TypeVectorLine / TypeVectorPolygon QgsProcessing.SourceType.TypeVectorLine / TypeVectorPolygon
24 QgsProcessingParameterNumber.Double QgsProcessingParameterNumber.Type.Double

These are the spellings the checker asks for. The check reads the code without running it, so it can't tell that these lines are version-gated; no Qt6 behavior was actually broken.

Verification

  • qgis/qgis:3.22 (where this branch runs, since 3.22 has no Qgis.GeometryType): the new spellings exist, equal the old aliases, and const.py imports cleanly.
  • QGIS 4.2.2: make test-all, 63 passed.
  • pre-commit passes under the host Python and Python 3.9 (CI's version).
  • The portal re-checks on upload, so the release after merge (2.1.2) will confirm the check passes.

https://claude.ai/code/session_017Nqnnwk4GAh8KymZVVDciM

The plugin portal's Qt6 check (a static scan) flagged the QGIS < 3.30/3.36
fallback branches in const.py. Use the scoped spellings it asks for
(QgsWkbTypes.GeometryType.LineGeometry, QgsProcessing.SourceType.TypeVectorLine,
QgsProcessingParameterNumber.Type.Double); they resolve to the same values on
QGIS 3.22, so there is no behavior change.

Claude-Session: https://claude.ai/code/session_017Nqnnwk4GAh8KymZVVDciM
@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@3829d74). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
PolygonsParallelToLine/src/const.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage        ?   59.40%           
=======================================
  Files           ?       13           
  Lines           ?      840           
  Branches        ?      120           
=======================================
  Hits            ?      499           
  Misses          ?      311           
  Partials        ?       30           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@elfpkck elfpkck self-assigned this Sep 26, 2026
@elfpkck elfpkck added the bug Fixes broken plugin behavior or a failing release/portal check label Sep 26, 2026
@elfpkck
elfpkck merged commit b169424 into main Sep 26, 2026
8 checks passed
@elfpkck
elfpkck deleted the fix/qt6-check-enums branch September 26, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes broken plugin behavior or a failing release/portal check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant