Stabilise MSC4222: support the stable use_state_after identifiers on /sync - #20170
Open
barodeur wants to merge 4 commits into
Open
Stabilise MSC4222: support the stable use_state_after identifiers on /sync#20170barodeur wants to merge 4 commits into
use_state_after identifiers on /sync#20170barodeur wants to merge 4 commits into
Conversation
Accept the stable `use_state_after` /sync query parameter and respond with the stable `state_after` field. The unstable identifiers are kept for a transition period: clients opting in with the unstable query parameter get the unstable response field name back.
Now that the feature is stable, `state_after` is always available and no longer gated per-user via the experimental features admin API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19414 (Support Matrix 1.16).
state_afterfor left rooms including post-leave lazy-loaded memberships #20169state_afterwhen thesincetoken falls inside a persist batch #20171Since Matrix 1.16, the spec defines the stable identifiers for MSC4222: the
use_state_afterquery parameter onGET /_matrix/client/v3/sync, and thestate_afterroom response field:Synapse so far only implemented the unstable identifiers (
org.matrix.msc4222.use_state_after/org.matrix.msc4222.state_after), gated behind themsc4222_enabledexperimental flag and the per-user experimental features admin API.This PR:
use_state_afterquery parameter, unconditionally, and responds with the stablestate_afterfield. The unstable query parameter is kept for a transition period; clients opting in with it get the unstable response field name back, so unstable-era clients see an unchanged wire format. If both parameters are set, the stable one wins.msc4222_enabledexperimental flag and themsc4222per-user feature from the experimental features admin API, since the behaviour is no longer gated.Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.