Refactor the federation transmission code to delineate transaction preparation and completion. - #20166
Open
reivilibre wants to merge 2 commits into
Open
Refactor the federation transmission code to delineate transaction preparation and completion.#20166reivilibre wants to merge 2 commits into
reivilibre wants to merge 2 commits into
Conversation
reivilibre
force-pushed
the
rei/sefb_piece1
branch
from
September 1, 2026 10:39
8d353f0 to
bec7fc0
Compare
reivilibre
force-pushed
the
rei/sefb_piece1
branch
from
September 1, 2026 11:05
bec7fc0 to
c3ff610
Compare
reivilibre
marked this pull request as ready for review
September 1, 2026 11:07
reivilibre
requested review from
anoadragon453
and removed request for
a team
September 1, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A key refactoring for, and split out of, #20165
Would be easier to land first to isolate the diff.
Should be a standalone change with no behavioural change.
Motivation is that #20165 will round-robin between 'main queue' transactions and 'sticky event' transactions.
To keep the data flow clear, I wanted to insert a typed struct (well,
attrsdataclass) as an interface between the 'preparation' of a transaction and its 'completion'.Doing this whilst keeping the asynchronous context manager style did not lead to a readable result in my opinion.
(I would also say the async context manager is a touch 'magic' / obscures control flow, but I suspect this is largely down to opinion.)
Replace _TransactionQueueManager with prepare/complete transaction methods