Skip to content

Add unit tests for is_compliant_user_id_localpart #20164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guillemo12 wants to merge 2 commits into
base: develop
Choose a base branch
from
+26 −0
Open

Add unit tests for is_compliant_user_id_localpart #20164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b3bdf8
Add unit tests for is_compliant_user_id_localpart
guillemo12 Aug 28, 2026
43bf0ea
Add changelog fragment for #20164
guillemo12 Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20164.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add unit tests for `is_compliant_user_id_localpart`. Contributed by @guillemo12.
25 changes: 25 additions & 0 deletions tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
UserID,
get_domain_from_id,
get_localpart_from_id,
is_compliant_user_id_localpart,
map_username_to_mxid_localpart,
)

Expand Down Expand Up @@ -350,3 +351,27 @@ class MyModel(BaseModel):

self.assertEqual(MyModel.model_validate_json('{"limit": 0}'), MyModel(limit=0))
self.assertEqual(MyModel.model_validate({"limit": 42}), MyModel(limit=42))


class IsCompliantUserIdLocalpartTestCase(unittest.TestCase):
def test_empty_string(self) -> None:
self.assertFalse(is_compliant_user_id_localpart(""))

def test_valid_characters(self) -> None:
# alphanumeric
self.assertTrue(is_compliant_user_id_localpart("alice"))
self.assertTrue(is_compliant_user_id_localpart("Alice123"))

# symbols between 0x21 and 0x7E
self.assertTrue(is_compliant_user_id_localpart("!@#$"))
self.assertTrue(is_compliant_user_id_localpart("bob.jones"))
self.assertTrue(is_compliant_user_id_localpart("=+-[]{}"))

def test_invalid_characters(self) -> None:
# non-ascii / outside range
self.assertFalse(is_compliant_user_id_localpart("álice"))
self.assertFalse(is_compliant_user_id_localpart("alice 123")) # space is 0x20
self.assertFalse(is_compliant_user_id_localpart("alice\t"))
self.assertFalse(is_compliant_user_id_localpart("alice\n"))
self.assertFalse(is_compliant_user_id_localpart("alice\x1f")) # control char
self.assertFalse(is_compliant_user_id_localpart("alice\x7f")) # DEL is 0x7F