Evict oldest OTKs if clients upload more than 500 keys - #20159
Closed
kaylendog wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
force-pushed
the
kaylendog/feat/limit-otks
branch
from
August 27, 2026 16:51
79dff2c to
448b1bf
Compare
Author
|
Closed in favour of #20162 which is both simpler and safer for pre-existing large homeservers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In matrix-org/matrix-js-sdk#5501, clients can upload arbitrary numbers of one-time keys (up to several thousand) while forgetting about their private halves (Vodozemac keeps 100 locally), leading peers to claim OTKs and use them to send pre-key sessions the client cannot decrypt, preventing new Olm sessions from being established.
No server-side limit exists in Synapse, and the specification does not prevent us from forgetting about older keys as long as we guarantee only one peer can ever claim a particular key. This limit would mitigate some of the effects of OTK starvation, although it is best paired with the relevant JS SDK fix, matrix-org/matrix-js-sdk#5503.
Notes
Two important things worth considering before merging:
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.