Stop treating unset display names and avatar URLs as profile fields with a null value. - #20145
Draft
reivilibre wants to merge 3 commits into
Draft
Stop treating unset display names and avatar URLs as profile fields with a null value.#20145reivilibre wants to merge 3 commits into
null value.#20145reivilibre wants to merge 3 commits into
Conversation
Update profiles-over-SS test to not expect phantom avatar_url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, treat them as absent fields as they feel like they should be.
The database implementation detail that these fields have a dedicated column with
NULLwhen unset is kept to the storage layer.
Follows: #20003
Push displayname & avatar_url special handling to storage layer
Update profiles-over-SS test to not expect phantom avatar_url
Update tests to no longer expect phantom
avatar_url