MSC4140: update error responses - #19539

Merged

AndrewFerr merged 68 commits into

element-hq:developfrom

AndrewFerr:msc4140-error-updates

Jul 11, 2026

Commits on Mar 9, 2026

MSC4140: impose limit of scheduled delayed events
AndrewFerr
committed
c2d1039
MSC4140: update error codes to match latest MSC
AndrewFerr
committed
c70c428
Add changelogs
AndrewFerr
committed
3b51b48

Commits on Mar 12, 2026

Assert against variable message, not literal
AndrewFerr
committed
ac2bed9
Put MSC4140 config near other one & allow stable
AndrewFerr
committed
e02f554

Commits on Mar 13, 2026

In test, assign default error message to variable
AndrewFerr
committed
2e01d7f
Explain reason for location of experimental config
AndrewFerr
committed
79a0218
Leave new config as experimental only
AndrewFerr
committed
a614ebb

Commits on Mar 16, 2026

Set Retry-After on delayed event limit error
AndrewFerr
committed
448bf17
Enforce max delayed event config to be positive
AndrewFerr
committed
43e14e9
Update copyright dates
AndrewFerr
committed
f69ddc1

Commits on Jun 2, 2026

Revert "Update copyright dates"
AndrewFerr
committed
437a034

Commits on Jun 5, 2026

Merge with 'develop'
AndrewFerr
committed
5dfc8b8

Commits on Jun 7, 2026

Use capabilities to convey delayed event limits
AndrewFerr
committed
1b19c13

Commits on Jun 8, 2026

Allow delayed event limit to be set to 0
AndrewFerr
committed
267a7e5
Rename variable to better indicate it as a time
AndrewFerr
committed
df09f8d
Elaborate comment on make_request time step
AndrewFerr
committed
3804db0
Remove unnecessary wait in test
AndrewFerr
committed
184b32d
Clarify config limits in errors & test comments
AndrewFerr
committed
c19df5d
Lint
AndrewFerr
committed
377cac4

Commits on Jun 12, 2026

Document special-case error for limit <= 0
AndrewFerr
committed
0b0aab1
Cover case of limit << num existing delayed events
AndrewFerr
committed
d62f440
Clarify test on ratelimit override
AndrewFerr
committed
4a9464c
Simplify delayed event limit test
AndrewFerr
committed
79a6f31
Use consistent keyvalues when applying limit
AndrewFerr
committed
34c5ce9
Use "err" instead of "e"

AndrewFerr
and
MadLittleMods
authored
2eea7f5
Fixups
AndrewFerr
committed
87ce5f3
Test limit << num existing delayed events
AndrewFerr
committed
e1a0ba4
Add alias to sub-SELECT, needed for PostgreSQL <16
AndrewFerr
committed
1a2895b

Commits on Jun 17, 2026

Apply suggestions from code review

AndrewFerr
and
MadLittleMods
authored
7bc51d7
Improve test comments

AndrewFerr
and
MadLittleMods
committed
56439ef
Fix typo in test docstring
AndrewFerr
committed
d2e84b7
Move all delayed event limit processing in handler
AndrewFerr
committed
af16899

Commits on Jun 18, 2026

Commits on Jun 26, 2026

Rename capability field to `max_delay_ms`
AndrewFerr
committed
a3d0def
In test, lift ratelimit before making any request
AndrewFerr
committed
45b6fc9
Test that is_processed events count against limit
AndrewFerr
committed
da30132
In test, rename time values to proper unit
AndrewFerr
committed
bcd5b61
Enforce & document positive limit in storage fn
AndrewFerr
committed
80b47aa
Restore comment on Retry-After lookup query
AndrewFerr
committed
06a6a9e
In tests, use closures instead of passing `*args`
AndrewFerr
committed
ba17cda
Tweak user limit tweak test
AndrewFerr
committed
17d1bfe

Commits on Jun 30, 2026

Use M_FORBIDDEN/403 for disallowed/exceeded delay
AndrewFerr
committed
2f0a302

Commits on Jul 8, 2026

Apply suggestions from code review

AndrewFerr
and
MadLittleMods
committed
4e0f0bc
Include values in error msg of too-large delay
AndrewFerr
committed
2b41710
Rename function for parsing delay from request

AndrewFerr
and
MadLittleMods
committed
ce02497
Add schema comment to explain is_processed
AndrewFerr
committed
c73d85f
Comment that test doesn't need specific errcode
AndrewFerr
committed
4a61644
Replace ValueError with assert
AndrewFerr
committed
73513bd
Delay Retry-After from response time, not request
AndrewFerr
committed
71942b0
Comment query on num_existing > limit case
AndrewFerr
committed
287eedf
Fix test coverage of num_existing > limit
AndrewFerr
committed
c186d1d
Test with a Duration for improved readability

AndrewFerr
and
MadLittleMods
committed
bf70a71
Use simpler query for num_existing == limit
AndrewFerr
committed
dce57e5

Commits on Jul 9, 2026

Commits on Jul 10, 2026

Merge with 'develop' & fix conflict in /versions
AndrewFerr
committed
0859de0
Check msc4140_enabled in handler
AndrewFerr
committed
c33d443
Rename limit-checking tests
AndrewFerr
committed
b384bb8
Reword comment in limit exceeded test

AndrewFerr
and
MadLittleMods
committed
0cab550
Test error shape, not namespace of errcode
AndrewFerr
committed
c5b8248
Merge with 'develop'
AndrewFerr
committed
4c597e4