Skip to content

Don't set custom profile fields to null when deletion is meant. - #34844

Open
reivilibre wants to merge 1 commit into
element-hq:developfrom
reivilibre:rei/user-status-delete-profile-field
Open

Don't set custom profile fields to null when deletion is meant.#34844
reivilibre wants to merge 1 commit into
element-hq:developfrom
reivilibre:rei/user-status-delete-profile-field

Conversation

@reivilibre

@reivilibre reivilibre commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Null is not interoperable as an allowable field value:

Servers MAY reject null values.
https://spec.matrix.org/v1.19/client-server-api/#put_matrixclientv3profileuseridkeyname

Synapse will enforce this to help in element-hq/synapse#20153

Complement updated in matrix-org/complement#914

Checklist

  • I have read through review guidelines and CONTRIBUTING.md.
  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)
    • (I am employed at Element and this change is on behalf of Element)

@reivilibre
reivilibre requested a review from a team as a code owner August 26, 2026 16:41
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Null is not interoperable as an allowable field value:

> Servers MAY reject null values.
— https://spec.matrix.org/v1.19/client-server-api/#put_matrixclientv3profileuseridkeyname

Synapse will enforce this to help in element-hq/synapse#20153
@reivilibre

Copy link
Copy Markdown
Contributor Author

I think this flaked? Please do ping me if that's not the case

@reivilibre
reivilibre marked this pull request as ready for review August 26, 2026 17:24
@florianduros

Copy link
Copy Markdown
Member

@reivilibre Tests are not flaking, a snapshot needs to be updated: https://github.com/element-hq/element-web/actions/runs/32991277157/job/98249165177?pr=34844

@reivilibre

Copy link
Copy Markdown
Contributor Author

@florianduros I don't get that, as I haven't changed any user-visible markup or anything like that. Any ideas?

@florianduros florianduros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it was a flake mb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants