Don't set custom profile fields to null when deletion is meant. - #34844
Open
reivilibre wants to merge 1 commit into
Open
Don't set custom profile fields to null when deletion is meant.#34844reivilibre wants to merge 1 commit into
null when deletion is meant.#34844reivilibre wants to merge 1 commit into
Conversation
|
|
Null is not interoperable as an allowable field value: > Servers MAY reject null values. — https://spec.matrix.org/v1.19/client-server-api/#put_matrixclientv3profileuseridkeyname Synapse will enforce this to help in element-hq/synapse#20153
reivilibre
force-pushed
the
rei/user-status-delete-profile-field
branch
from
August 26, 2026 16:43
3d54a9e to
f3b61bc
Compare
reivilibre
marked this pull request as draft
August 26, 2026 17:10
Contributor
Author
|
I think this flaked? Please do ping me if that's not the case |
reivilibre
marked this pull request as ready for review
August 26, 2026 17:24
Member
|
@reivilibre Tests are not flaking, a snapshot needs to be updated: https://github.com/element-hq/element-web/actions/runs/32991277157/job/98249165177?pr=34844 |
Contributor
Author
|
@florianduros I don't get that, as I haven't changed any user-visible markup or anything like that. Any ideas? |
florianduros
approved these changes
Aug 27, 2026
florianduros
left a comment
Member
There was a problem hiding this comment.
Indeed, it was a flake mb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null is not interoperable as an allowable field value:
Synapse will enforce this to help in element-hq/synapse#20153
Complement updated in matrix-org/complement#914
Checklist
public/exportedsymbols have accurate TSDoc documentation.