Skip to content

feat(electron-publish): add support for a read/write token to publish to a private gitlab repository #9680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andreamarelli wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(electron-publish): add support for a read/write token to publish to a private gitlab repository #9680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/electron-publish/src/gitlabPublisher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ export class GitlabPublisher extends HttpPublisher {
) {
super(context, true)

let token = info.token || null
if (isEmptyOrSpaces(token)) {
token = process.env.GITLAB_TOKEN || null
let token = info.token
if (isEmptyOrSpaces(token) || process.env.GITLAB_RELEASE_TOKEN) {
token = process.env.GITLAB_RELEASE_TOKEN ? process.env.GITLAB_RELEASE_TOKEN : process.env.GITLAB_TOKEN || null
Copy link
Copy Markdown
Collaborator

@mmaietta mmaietta Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the GitlabOptions description about this new env var?

electron-builder/packages/builder-util-runtime/src/publishOptions.ts

Lines 168 to 170 in 96d782a

* Define `GITLAB_TOKEN` environment variable.
*/
export interface GitlabOptions extends PublishConfiguration {

Also, is this intended to always override the GITLAB_TOKEN env var even if the RELEASE_TOKEN is present? This logic seems odd to me but at least should be described in the docs.

After updating the publishOptions.ts tsdocs, please run pnpm generate-all for the schema and site docs.

if (isEmptyOrSpaces(token)) {
throw new InvalidConfigurationError(`GitLab Personal Access Token is not set, neither programmatically, nor using env "GITLAB_TOKEN"`)
Copy link
Copy Markdown
Collaborator

@mmaietta mmaietta Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message should be updated to mention the GITLAB_RELEASE_TOKEN as well.

}
Expand Down
Loading