chore: v27 migration to ESM-only package (BREAKING)#9544
Open
chore: v27 migration to ESM-only package (BREAKING)#9544
Conversation
… `env: { COREPACK_ENABLE_STRICT: "0", ...process.env },` to allow `npm list` to work across environments. extract fallback node collector (Traversal) to separate class due to differing parsing logic from NPM collector
# Conflicts: # packages/app-builder-lib/package.json # packages/dmg-builder/package.json # packages/electron-builder-squirrel-windows/package.json # packages/electron-builder/package.json
…m-migration # Conflicts: # packages/app-builder-lib/src/node-module-collector/bunNodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/npmNodeModulesCollector.ts # packages/app-builder-lib/src/util/appFileCopier.ts
# Conflicts: # packages/app-builder-lib/package.json # packages/app-builder-lib/src/asar/asarUtil.ts # packages/app-builder-lib/src/binDownload.ts # packages/app-builder-lib/src/node-module-collector/bunNodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/index.ts # packages/app-builder-lib/src/node-module-collector/moduleCache.ts # packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/npmNodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/pnpmNodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/traversalNodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/types.ts # packages/app-builder-lib/src/node-module-collector/yarnBerryNodeModulesCollector.ts # packages/app-builder-lib/src/node-module-collector/yarnNodeModulesCollector.ts # packages/app-builder-lib/src/publish/PublishManager.ts # packages/app-builder-lib/src/targets/FlatpakTarget.ts # packages/app-builder-lib/src/targets/archive.ts # packages/app-builder-lib/src/util/appFileCopier.ts # packages/dmg-builder/package.json # packages/dmg-builder/src/dmgUtil.ts # packages/electron-builder-squirrel-windows/package.json # packages/electron-builder/package.json # packages/electron-publish/package.json # packages/electron-updater/src/differentialDownloader/DataSplitter.ts # pnpm-lock.yaml # test/src/helpers/packTester.ts # test/src/updater/blackboxUpdateTest.ts # test/src/updater/differentialUpdateTest.ts
🦋 Changeset detectedLatest commit: 3ba131a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…m-migration # Conflicts: # packages/app-builder-lib/package.json # packages/app-builder-lib/src/targets/appimage/appImageUtil.ts # packages/app-builder-lib/src/toolsets/linux.ts # packages/builder-util-runtime/package.json # packages/builder-util/package.json # packages/dmg-builder/package.json # packages/electron-builder-squirrel-windows/package.json # packages/electron-builder/package.json # packages/electron-publish/package.json # test/src/updater/blackboxUpdateTest.ts
mmaietta
force-pushed
the
chore/esm-migration
branch
from
52191a7 to
3b38b0e
Compare
…ng the traditional `.` root export
…m-migration # Conflicts: # packages/app-builder-lib/src/util/yarn.ts # test/src/HoistedNodeModuleTest.ts
mmaietta
changed the title
# Conflicts: # test/src/helpers/updaterTestUtil.ts
skmedix
reviewed
May 8, 2026
| "electron": "35.7.5" | ||
| }, | ||
| "typings": "./out/main.d.ts", | ||
| "types": "./out/main.d.ts", |
There was a problem hiding this comment.
Is this still correct since main.js is gone?
| "@babel/preset-env": "7.24.8", | ||
| "@babel/preset-react": "7.24.7", | ||
| "@types/debug": "4.1.7", | ||
| "@types/fs-extra": "9.0.13", |
There was a problem hiding this comment.
You can probably bump it to v11 In all package.jsons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9483!! (see for additional details there)