Skip to content

Allow expired cache shapes to attempt self-healing once after maxRetries exceeded #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evanob wants to merge 1 commit into from
Closed

Allow expired cache shapes to attempt self-healing once after maxRetries exceeded #4085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/typescript-client/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,7 @@ export class ShapeStream<T extends Row<unknown> = Row>
#fastLoopMaxCount = 5
#pendingRequestShapeCacheBuster?: string
#maxSnapshotRetries = 5
_expiredShapeRecoveryKey: string | null = null

constructor(options: ShapeStreamOptions<GetExtensions<T>>) {
this.options = { subscribe: true, ...options }
Expand Down Expand Up @@ -1241,6 +1242,14 @@ export class ShapeStream<T extends Row<unknown> = Row>
// Cancel the response body to release the connection before retrying.
await response.body?.cancel()
if (transition.exceededMaxRetries) {
if (shapeKey && this._expiredShapeRecoveryKey !== shapeKey) {
this._expiredShapeRecoveryKey = shapeKey
expiredShapesCache.delete(shapeKey)
this.#reset()
throw new StaleCacheError(
`Expired handle entry evicted for self-healing retry`
)
}
throw new FetchError(
502,
undefined,
Expand Down