Skip to content

fix forced-shutdown (double SIGINT) behaviour for JRuby 10 #19017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaauie merged 1 commit into from
Apr 21, 2026
+3 −1
Merged

fix forced-shutdown (double SIGINT) behaviour for JRuby 10 #19017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion logstash-core/src/main/java/org/logstash/Logstash.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ public static void main(final String... args) {

private static void installGlobalUncaughtExceptionHandler() {
Thread.setDefaultUncaughtExceptionHandler((thread, e) -> {
if (e instanceof Error) {
if (e instanceof org.jruby.exceptions.SystemExit) {
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nit: we can import org.jruby.exceptions.SystemExit on the top to keep the standard importing import org.jruby.exceptions.*

halt(1);
} else if (e instanceof Error) {
handleFatalError("uncaught error (in thread " + thread.getName() + ")", e);
} else {
LOGGER.error("uncaught exception (in thread " + thread.getName() + ")", e);
Expand Down
Loading