require java 21, since jruby 10 requires it#19010
Merged
yaauie merged 1 commit intoelastic:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
💚 Build Succeeded
|
donoghuc
requested changes
Apr 16, 2026
Member
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Looks good, just one suggestion/question about deprecation logging.
|
|
||
| if JavaVersion::CURRENT < JavaVersion::JAVA_17 | ||
| deprecation_logger.deprecated I18n.t("logstash.runner.java.version_17_minimum", | ||
| if JavaVersion::CURRENT < JavaVersion::JAVA_21 |
Member
There was a problem hiding this comment.
I think this is now no longer reachable? I think bailOnOldJava would stop execution before this can execute. We would introduce this again if there were multiple java versions supported (and one was to be deprecated soon).
Member
Author
There was a problem hiding this comment.
You're right that it is likely unreachable. Let's file a separate ticket to chase it. For now I'm just updating the bits that are there just in case there is a path to it that I can't think of.
Member
Author
|
@Mergifyio backport 9.4 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
(cherry picked from commit 4a51726)
2 tasks
yaauie
added a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Sets the minimum version of Java to 21.
What does this PR do?
Updates the check in the
JVMOptionsParserto provide helpful output when logstash is invoked with a JVM that does not meet JRuby 10's minimum requirement.Why is it important/What is the impact to the user?
Without this, invoking Logstash on JVM 17 produces an obscure and unhelpful error message:
With it, the message is helpful and clear:
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
(jenv shell 17; bin/logstash -e "")LS_JAVA_HOME=/path/to/java17 bin/logstash -e ""Related issues
Use cases