Skip to content

pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin#18977

Merged
jsvd merged 2 commits intoelastic:mainfrom
jsvd:pin_multijson_1_19
Apr 10, 2026
Merged

pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin#18977
jsvd merged 2 commits intoelastic:mainfrom
jsvd:pin_multijson_1_19

Conversation

@jsvd
Copy link
Copy Markdown
Member

@jsvd jsvd commented Apr 10, 2026

multi_json 1.20.0 is a very big release with drop of support for 9.4, multiple changes to its adapters and the first version that publishes java and ruby platform gems separately.

The java version introduces a concurrent-ruby pin we're not yet ready to respect, leading bundler to pick the ruby version since it doesn't have C extensions, but also doesn't carry jruby specific parts like jrjackson backend and use of java concurrency primitives.

So we pin the dependency for now at ~> 1.19.x.

Not pinning causes the ruby version to be installed, and then the orphan cleanup task removes the dependency by mistake, leading to failures in tests and potentially in runtime too.

…current-ruby pin

multi_json 1.20.0 is a very big release with drop of support for 9.4,
multiple changes to its adapters and the first version that publishes
java and ruby platform gems separately.

The java version introduces a concurrent-ruby pin we're not yet ready to
respect, leading bundler to pick the ruby version since it doesn't have
C extensions, but also doesn't carry jruby specific parts like jrjackson
backend and use of java concurrency primitives.

So we pin the dependency for now at ~> 1.19.x.
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 10, 2026

This pull request does not have a backport label. Could you fix it @jsvd? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@jsvd
Copy link
Copy Markdown
Member Author

jsvd commented Apr 10, 2026

run exhaustive tests

Copy link
Copy Markdown
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qa/integration/Gemfile also need to pin gem "multi_json", "~> 1.19.1" ? Unit test is passed but IT still fail

@jsvd
Copy link
Copy Markdown
Member Author

jsvd commented Apr 10, 2026

run exhaustive tests

@elasticmachine
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

History

@jsvd jsvd merged commit 597df17 into elastic:main Apr 10, 2026
12 checks passed
@jsvd
Copy link
Copy Markdown
Member Author

jsvd commented Apr 10, 2026

@Mergifyio backport 9.4

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 10, 2026

backport 9.4

✅ Backports have been created

Details

Git reported the following error:

To https://github.com/elastic/logstash
 ! [rejected]            mergify/bp/9.4/pr-18977 -> mergify/bp/9.4/pr-18977 (non-fast-forward)
error: failed to push some refs to 'https://github.com/elastic/logstash'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

mergify Bot pushed a commit that referenced this pull request Apr 10, 2026
…current-ruby pin (#18977)

* pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin

multi_json 1.20.0 is a very big release with drop of support for 9.4,
multiple changes to its adapters and the first version that publishes
java and ruby platform gems separately.

The java version introduces a concurrent-ruby pin we're not yet ready to
respect, leading bundler to pick the ruby version since it doesn't have
C extensions, but also doesn't carry jruby specific parts like jrjackson
backend and use of java concurrency primitives.

So we pin the dependency for now at ~> 1.19.x.

* move pin to logstash-core/logstash-core.gemspec so it fixes core and qa testing

(cherry picked from commit 597df17)
jsvd added a commit that referenced this pull request Apr 10, 2026
…current-ruby pin (#18977) (#18979)

* pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin

multi_json 1.20.0 is a very big release with drop of support for 9.4,
multiple changes to its adapters and the first version that publishes
java and ruby platform gems separately.

The java version introduces a concurrent-ruby pin we're not yet ready to
respect, leading bundler to pick the ruby version since it doesn't have
C extensions, but also doesn't carry jruby specific parts like jrjackson
backend and use of java concurrency primitives.

So we pin the dependency for now at ~> 1.19.x.

* move pin to logstash-core/logstash-core.gemspec so it fixes core and qa testing

(cherry picked from commit 597df17)

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants