pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin#18977
Merged
jsvd merged 2 commits intoelastic:mainfrom Apr 10, 2026
Merged
pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin#18977jsvd merged 2 commits intoelastic:mainfrom
jsvd merged 2 commits intoelastic:mainfrom
Conversation
…current-ruby pin multi_json 1.20.0 is a very big release with drop of support for 9.4, multiple changes to its adapters and the first version that publishes java and ruby platform gems separately. The java version introduces a concurrent-ruby pin we're not yet ready to respect, leading bundler to pick the ruby version since it doesn't have C extensions, but also doesn't carry jruby specific parts like jrjackson backend and use of java concurrency primitives. So we pin the dependency for now at ~> 1.19.x.
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
kaisecheng
approved these changes
Apr 10, 2026
Member
Author
|
run exhaustive tests |
kaisecheng
requested changes
Apr 10, 2026
Member
Author
|
run exhaustive tests |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
kaisecheng
approved these changes
Apr 10, 2026
Member
Author
|
@Mergifyio backport 9.4 |
Contributor
✅ Backports have been createdDetails
Git reported the following error: |
mergify Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
…current-ruby pin (#18977) * pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin multi_json 1.20.0 is a very big release with drop of support for 9.4, multiple changes to its adapters and the first version that publishes java and ruby platform gems separately. The java version introduces a concurrent-ruby pin we're not yet ready to respect, leading bundler to pick the ruby version since it doesn't have C extensions, but also doesn't carry jruby specific parts like jrjackson backend and use of java concurrency primitives. So we pin the dependency for now at ~> 1.19.x. * move pin to logstash-core/logstash-core.gemspec so it fixes core and qa testing (cherry picked from commit 597df17)
jsvd
added a commit
that referenced
this pull request
Apr 10, 2026
…current-ruby pin (#18977) (#18979) * pin multi_json to 1.19.1 since 1.20.0 has java variant with newer concurrent-ruby pin multi_json 1.20.0 is a very big release with drop of support for 9.4, multiple changes to its adapters and the first version that publishes java and ruby platform gems separately. The java version introduces a concurrent-ruby pin we're not yet ready to respect, leading bundler to pick the ruby version since it doesn't have C extensions, but also doesn't carry jruby specific parts like jrjackson backend and use of java concurrency primitives. So we pin the dependency for now at ~> 1.19.x. * move pin to logstash-core/logstash-core.gemspec so it fixes core and qa testing (cherry picked from commit 597df17) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multi_json 1.20.0 is a very big release with drop of support for 9.4, multiple changes to its adapters and the first version that publishes java and ruby platform gems separately.
The java version introduces a concurrent-ruby pin we're not yet ready to respect, leading bundler to pick the ruby version since it doesn't have C extensions, but also doesn't carry jruby specific parts like jrjackson backend and use of java concurrency primitives.
So we pin the dependency for now at ~> 1.19.x.
Not pinning causes the ruby version to be installed, and then the orphan cleanup task removes the dependency by mistake, leading to failures in tests and potentially in runtime too.