[On Week] Replace Loki with Playwright-based approach and run in CI#9594
Draft
weronikaolejniczak wants to merge 30 commits intoelastic:mainfrom
Draft
[On Week] Replace Loki with Playwright-based approach and run in CI#9594weronikaolejniczak wants to merge 30 commits intoelastic:mainfrom
weronikaolejniczak wants to merge 30 commits intoelastic:mainfrom
Conversation
06a29a1 to
0140de5
Compare
aaea671 to
1267344
Compare
Collaborator
💚 Build Succeeded
History
|
9d4cae3 to
ac0df3c
Compare
Collaborator
💚 Build Succeeded
History
|
23 tasks
Collaborator
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dynamic jobs
Now I know we might not typically want a dynamic job injection but because "building and deploying a website" is something completely independent from "building and deploying a Storybook", we might want to run both in parallel, have separate bash scripts for them AND it means we save some CI time:
API Changes
N/A
Screenshots
N/A
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None
Release Readiness
Documentation: {link to docs page(s)}Figma: {link to Figma or issue}Migration guide: {steps or link, for breaking/visual changes or deprecations}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
chore(eui): add VRT baseline screenshotschore(eui): update VRT baseline screenshotsChecklist before marking Ready for Review
QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen readerQA: Tested in CodeSandbox and KibanaQA: Tested docs changesChangelog: Added changelog entryBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist