Skip to content

[FieldValueToggleGroupFilter] Migrate from class to function component #9534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weronikaolejniczak merged 3 commits into from
May 4, 2026
+40 −36
Merged

[FieldValueToggleGroupFilter] Migrate from class to function component #9534

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae874ff
[FieldValueToggleGroupFilter] Migrate from class to function componen…
CollegeRideOut Mar 25, 2026
319e908
remove Component from import and ran prettier (also yarn lint gave 0 …
CollegeRideOut Mar 25, 2026
75c6b8d
Merge branch 'main' into 9474-field-value-toggle-group-filter-function
CollegeRideOut Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 40 additions & 36 deletions packages/eui/src/components/search_bar/filters/field_value_toggle_group_filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import React, { Component } from 'react';
import React, { FC } from 'react';
import { EuiFilterButton } from '../../filter_group';
import { Query } from '../query';
import { OperatorType } from '../query/ast';
Expand Down Expand Up @@ -35,12 +35,14 @@ export interface FieldValueToggleGroupFilterProps {
onChange: (value: Query) => void;
}

export class FieldValueToggleGroupFilter extends Component<FieldValueToggleGroupFilterProps> {
resolveDisplay(
export const FieldValueToggleGroupFilter: FC<
FieldValueToggleGroupFilterProps
> = (props) => {
const resolveDisplay = (
config: FieldValueToggleGroupFilterConfigType,
query: Query,
item: FieldValueToggleGroupFilterItemType
) {
) => {
const clause = query.getSimpleFieldClause(config.field, item.value);
if (clause) {
if (Query.isMust(clause)) {
Expand All @@ -52,41 +54,43 @@ export class FieldValueToggleGroupFilter extends Component<FieldValueToggleGroup
};
}
return { active: false, name: item.name };
}
};

valueChanged(item: FieldValueToggleGroupFilterItemType, active: boolean) {
const { field } = this.props.config;
const valueChanged = (
item: FieldValueToggleGroupFilterItemType,
active: boolean
) => {
const { field } = props.config;
const { value, operator } = item;
const query = active
? this.props.query.removeSimpleFieldClauses(field)
: this.props.query
? props.query.removeSimpleFieldClauses(field)
: props.query
.removeSimpleFieldClauses(field)
.addSimpleFieldValue(field, value, true, operator);
this.props.onChange(query);
}
props.onChange(query);
};

render() {
const { config, query } = this.props;
return config.items.map((item, index) => {
const { active, name } = this.resolveDisplay(config, query, item);
const onClick = () => {
this.valueChanged(item, active);
};
const key = `field_value_toggle_filter_item_${index}`;
const isLastItem = index === config.items.length - 1;
return (
<EuiFilterButton
key={key}
onClick={onClick}
isSelected={active}
hasActiveFilters={active}
aria-pressed={!!active}
withNext={!isLastItem}
isToggle
>
{name}
</EuiFilterButton>
);
});
}
}
const { config, query } = props;

return config.items.map((item, index) => {
const { active, name } = resolveDisplay(config, query, item);
const onClick = () => {
valueChanged(item, active);
};
const key = `field_value_toggle_filter_item_${index}`;
const isLastItem = index === config.items.length - 1;
return (
<EuiFilterButton
key={key}
onClick={onClick}
isSelected={active}
hasActiveFilters={active}
aria-pressed={!!active}
withNext={!isLastItem}
isToggle
>
{name}
</EuiFilterButton>
);
});
};