Skip to content

MongoDB: Make sure to end the right spans #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikker wants to merge 3 commits into from
Closed

MongoDB: Make sure to end the right spans #1209

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80bc581
MongoDB spy: Make sure to close the right span
Dec 7, 2021
0a6af4a
Update lib/elastic_apm/spies/mongo.rb
mikker Dec 7, 2021
22265ad
Update lib/elastic_apm/spies/mongo.rb
mikker Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elastic_apm/spies/mongo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def pop_event(event)
span = events.delete(event.operation_id)
Copy link
Copy Markdown
Contributor Author

@mikker mikker Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the agent is not recording, will this not be a problem? We have an early return in push_event if there's no transaction. Shouldn't we have the same check here?

return unless (curr = ElasticAPM.current_span)
Comment thread
mikker marked this conversation as resolved.
Outdated

curr == span && ElasticAPM.end_span
curr == span && ElasticAPM.end_span(span)
Comment thread
mikker marked this conversation as resolved.
Outdated
end

def build_context(event)
Expand Down