test(monero-rpc-pool): add unit tests for parsing, database, pool and proxy (bounty #801) - #1204
Open
BlankHtmlPage wants to merge 1 commit into
Open
BlankHtmlPage wants to merge 1 commit into
BlankHtmlPage wants to merge 1 commit into
Conversation
… proxy Covers parsing and formatting, database and migrations, pool status and statistics broadcast, proxy end to end handling, network connection reuse, bandwidth window, start up status and stats endpoint. Tests live in src/ because CI runs `cargo test --lib`, which never sees a tests/ directory. Verified locally: 32/32 passed on multiple runs, `cargo fmt --check -p monero-rpc-pool` is clean. No production changes. `tempfile` was added as a dev-dependency, because the tests need their own SQLite file, swap and `monero-sys` already use it; plus it was already in Cargo.lock.
BlankHtmlPage
marked this pull request as ready for review
September 21, 2026 11:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers parsing and formatting, database and migrations, pool status and statistics broadcast, proxy end to end handling, network connection reuse, bandwidth window, startup status and stats endpoint.
Verified locally: 32/32 passed on all runs,
cargo fmt --check -p monero-rpc-poolis clean.AI was used for code (GLM-5.3 by Z.ai in Pi coding agent); I ran the tests and authored the commit and this PR myself.
No production changes.
tempfilewas added as a dev-dependency, because the database tests need their own SQLite file, swap andmonero-sysalready use it; plus it was already in Cargo.lock.While running the tests, I've hit three things (didn't touch any):
monero-rpc-poolbin doesn't compile (rustlsringfeature isn't enabled)The workspace
testjob already fails at base commit 0e17c7f (swap-core, swap-machine); this PR doesn't touch either.Related to #801