Conversation
|
We are not accepting vibe coded PRs. https://github.com/eigenwallet/core/blob/master/AI_POLICY.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
monero_sysandmonero_cpp.tracing-monero-sys*.logprefix so wallet-thread/channel-close diagnostics can be inspected without filtering through unrelated wallet/RPC traffic.Why
Issue #695 needs better diagnostics for unexpected monero-sys channel closure. The maintainer asked for monero-sys trace logs in their own file, so this PR isolates the Rust wrapper and C++ callback targets while leaving existing general and wallet logs intact.
Validation
git diff --checkrg -n "tracing-monero-sys|MONERO_SYS_CRATES|monero-sys" swap/src/common/tracing_util.rsI could not run Rust tests locally because this environment still has no
cargoorrustfmtavailable.Closes #695