Repository navigation
fix(monero-sys): make patch application idempotent across rebuilds - #1143
Merged
Merged
Conversation
build.rs detected an already-applied patch by reverse-applying it. When two
patches modify adjacent lines of the same file, applying one shifts the
other's hunk context, so the reverse check fails on later builds and the
forward apply then panics ('error applying hunk #1'). A fresh checkout works
but the second compile fails.
Instead, reconstruct each target file's expected content from its pristine
(committed) version plus every patch that touches it, and write only when the
working file differs. This is a byte-exact comparison rather than a fuzzy
reverse check, self-heals a partially-applied tree, and never rewrites an
already-correct file (which would change its mtime and force a full C++
rebuild). Pristine content is read via 'git show HEAD:<path>' from the
repository that owns each file, so targets in nested submodules (e.g.
external/randomx) resolve correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.