fix: use find_if instead of iterator loops with break by wdconinc · Pull Request #2383 · eic/EICrecon

wdconinc · 2026-01-31T21:22:00Z

Briefly, what does this PR introduce?

Needs:

podio-1.3 (Make collection iterators fulfill LegacyInputIterator and input_iterator concept AIDASoft/podio#626), in eic-shell as of 2025.09

In a few places, due to historical limitations of podio collections, we were still using iterator-based loops with tests and early break to do things that are more nicely done with find_if nowadays. This PR introduces the find_if based approach in a few cases, and removes a comment block complaints about all that used to not work...

What kind of change does this PR introduce?

Bug fix (issue: tech debt)
New feature (issue #__)
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copilot

Pull request overview

Refactors a few remaining “iterator loop + break” patterns into std::find_if-based lookups now that podio collections support this more cleanly, and removes outdated commented examples.

Changes:

Replace manual association-search loops with std::find_if in scattered-electron association logic.
Update beam-particle selection helpers in Beam.h to use std::find_if.
Remove a large block of obsolete commented-out iteration examples.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`src/algorithms/reco/ScatteredElectronsTruth.cc`	Uses `std::find_if` to locate the truth↔reco association instead of a manual loop.
`src/algorithms/reco/InclusiveKinematicsElectron.cc`	Removes outdated commented code demonstrating older iteration patterns.
`src/algorithms/reco/HadronicFinalState.cc`	Uses `std::find_if` for truth↔reco association lookup instead of a manual loop.
`src/algorithms/reco/Beam.h`	Refactors “find first with PDG/status” helpers to `std::find_if` and adds `<algorithm>`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-14T22:01:02Z

Capybara summary for PR 2383

Last updated 2026-02-14T18:03-05:00 9309d0c

) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/22023709298. Please merge this PR into the branch `find_if` to resolve failures in PR #2383. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

simonge

Looks good. Capybara differences appear to be from other simultaneous PRs.

### Briefly, what does this PR introduce? Needs: - [x] podio-1.3 (AIDASoft/podio#626), in eic-shell as of 2025.09 In a few places, due to historical limitations of podio collections, we were still using iterator-based loops with tests and early break to do things that are more nicely done with `find_if` nowadays. This PR introduces the `find_if` based approach in a few cases, and removes a comment block complaints about all that used to not work... ### What kind of change does this PR introduce? - [x] Bug fix (issue: tech debt) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: epic-capybara <139920704+epic-capybara@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

wdconinc · 2026-02-17T16:17:54Z

It seems GitHub is having issues with checkout. I'll keep retrying the merge queue...

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This reverts commit e4db126.

) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/22023709298. Please merge this PR into the branch `find_if` to resolve failures in PR #2383. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

### Briefly, what does this PR introduce? Needs: - [x] podio-1.3 (AIDASoft/podio#626), in eic-shell as of 2025.09 In a few places, due to historical limitations of podio collections, we were still using iterator-based loops with tests and early break to do things that are more nicely done with `find_if` nowadays. This PR introduces the `find_if` based approach in a few cases, and removes a comment block complaints about all that used to not work... ### What kind of change does this PR introduce? - [x] Bug fix (issue: tech debt) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: epic-capybara <139920704+epic-capybara@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 31, 2026 21:22

Copilot started reviewing on behalf of wdconinc January 31, 2026 21:22 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

Comment thread src/algorithms/reco/HadronicFinalState.cc

Comment thread src/algorithms/reco/ScatteredElectronsTruth.cc

Comment thread src/algorithms/reco/Beam.h

Comment thread src/algorithms/reco/HadronicFinalState.cc

Copilot AI review requested due to automatic review settings January 31, 2026 21:29

Copilot started reviewing on behalf of wdconinc January 31, 2026 21:30 View session

This comment was marked as resolved.

Sign in to view

Copilot AI review requested due to automatic review settings January 31, 2026 21:32

Copilot started reviewing on behalf of wdconinc January 31, 2026 21:33 View session

This comment was marked as resolved.

Sign in to view

wdconinc marked this pull request as draft January 31, 2026 21:45

wdconinc force-pushed the find_if branch from 1698f80 to eb54dd8 Compare February 14, 2026 20:23

wdconinc marked this pull request as ready for review February 14, 2026 20:24

Copilot AI review requested due to automatic review settings February 14, 2026 20:24

wdconinc enabled auto-merge February 14, 2026 20:25

Copilot AI reviewed Feb 14, 2026

View reviewed changes

Copilot started reviewing on behalf of wdconinc February 14, 2026 20:40 View session

epic-capybara mentioned this pull request Feb 14, 2026

fix: use find_if instead of iterator loops with break (fix: iwyu) #2471

Merged

wdconinc temporarily deployed to github-pages February 14, 2026 21:58 — with GitHub Actions Inactive

wdconinc temporarily deployed to github-pages February 14, 2026 23:03 — with GitHub Actions Inactive

wdconinc requested review from a team and simonge and removed request for a team February 14, 2026 23:26

simonge approved these changes Feb 17, 2026

View reviewed changes

wdconinc added this pull request to the merge queue Feb 17, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 17, 2026

wdconinc added this pull request to the merge queue Feb 17, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 17, 2026

wdconinc added this pull request to the merge queue Feb 17, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 17, 2026

wdconinc and others added 7 commits February 17, 2026 11:19

fix: use find_if instead of iterator loops with break

e18a4b7

fix: use find_if in Beam.h helpers

c68abf3

fix: includes

587adad

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: use operator->

285bc6e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: include algorithm

c464fb0

Revert "fix: use operator->"

a011d07

This reverts commit e4db126.

Copilot AI review requested due to automatic review settings February 17, 2026 17:19

wdconinc force-pushed the find_if branch from 9309d0c to fde42d9 Compare February 17, 2026 17:19

wdconinc enabled auto-merge February 17, 2026 17:19

Copilot started reviewing on behalf of wdconinc February 17, 2026 17:19 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

wdconinc added this pull request to the merge queue Feb 17, 2026

Merged via the queue into main with commit c63be14 Feb 17, 2026
149 of 151 checks passed

wdconinc deleted the find_if branch February 17, 2026 18:48

Navigation Menu

Uh oh!

fix: use find_if instead of iterator loops with break - #2383

fix: use find_if instead of iterator loops with break#2383
wdconinc merged 7 commits into
mainfrom
find_if

wdconinc commented Jan 31, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

simonge left a comment

Uh oh!

Uh oh!

Uh oh!

wdconinc commented Feb 17, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wdconinc commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Capybara summary for PR 2383

Uh oh!

simonge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wdconinc commented Feb 17, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wdconinc commented Jan 31, 2026 •

edited

Loading

github-actions Bot commented Feb 14, 2026 •

edited

Loading