Add name to rewrite and birewrite commands#871
Conversation
name to rewrite and birewrite commands
|
Hey @saulshanabrook , hope you are doing well! Would appreciate your review on this. As a reminder, this was motivated here: egraphs-good/egglog-python#416. Thank you! |
saulshanabrook
left a comment
There was a problem hiding this comment.
This looks great! Thank you so much for adding this feature :)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 87.18% 87.17% -0.01%
==========================================
Files 87 87
Lines 24933 24953 +20
==========================================
+ Hits 21737 21754 +17
- Misses 3196 3199 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
Resolves #870
Key changes:
pub name: Stringfield toGenericRewrite:nameoption onrewriteandbirewrite(mirrors existing:nameonrule)