Skip to content

feat(search): show facets count - #210

Closed
razvanMiu wants to merge 12 commits into
developfrom
facets_count
Closed

feat(search): show facets count#210
razvanMiu wants to merge 12 commits into
developfrom
facets_count

fix tests

cd7be54
Select commit
Loading
Failed to load commit list.
Jenkins - ci.eionet.europa.eu / Jenkins failed Oct 28, 2025 in 3m 9s

Testing/Volto 17/ES lint: error in 'sh' step

Testing / Volto 17 / Volto 17 / ES lint / Shell Script

Error in sh step, with arguments docker run --rm --name="$IMAGE_NAME-eslint" --entrypoint=make --workdir=/app/src/addons/$GIT_NAME $IMAGE_NAME-frontend lint.

script returned exit code 2
Build log
+ docker run --rm --name=jenkins-volto-addons-volto-eea-website-theme-pr-210-122-eslint --entrypoint=make --workdir=/app/src/addons/volto-eea-website-theme jenkins-volto-addons-volto-eea-website-theme-pr-210-122-frontend lint
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

/app/src/addons/volto-eea-website-theme/src/customizations/volto/components/manage/Blocks/Search/components/Facets.jsx
  109:18  error  Replace `⏎············rewriteOptions·=·(name,·options)·=>·options,` with `·rewriteOptions·=·(name,·options)·=>·options·}·=`  prettier/prettier
  111:11  error  Replace `}·=` with `·`                                                                                                       prettier/prettier

/app/src/addons/volto-eea-website-theme/src/customizations/volto/components/manage/Blocks/Search/hocs/withQueryString.jsx
  18:11  warning  The 'indexes' logical expression could make the dependencies of useEffect Hook (at line 24) change on every render. Move it inside the useEffect callback. Alternatively, wrap the initialization of 'indexes' in its own useMemo() Hook  react-hooks/exhaustive-deps

/app/src/addons/volto-eea-website-theme/src/customizations/volto/components/manage/Blocks/Search/hocs/withSearch.jsx
   40:10  error  Replace `⏎····types:·facetWidgetTypes,⏎··}·=` with `·types:·facetWidgetTypes·}·=⏎···`  prettier/prettier
  104:10  error  Replace `⏎····types:·facetWidgetTypes,⏎··}·=` with `·types:·facetWidgetTypes·}·=⏎···`  prettier/prettier

✖ 5 problems (4 errors, 1 warning)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

make: *** [Makefile:122: lint] Error 1

Details

  • Declarative: Checkout SCM (9.6 sec)
    • Declarative: Tool Install (3.3 sec)
      • Release (2.8 sec)
      • Check if testing needed (2.4 sec)
      • Testing (2 min 38 sec)
        • Volto 17 (28 ms)
          • Volto 17 (2 min 27 sec)
            • Build test image (1 min 40 sec)
            • Fix code (2.5 sec)
            • ES lint (10 sec)
              Error: script returned exit code 2 - logs
            • Style lint (2.2 sec)
            • Prettier (2.2 sec)
            • Unit tests (3 sec)
            • Integration tests (2.3 sec)
            • Report to SonarQube (2.3 sec)
        • Volto 16 (26 sec)
          • Volto 16 (21 sec)
            • Build test image (2.6 sec)
            • Unit tests Volto 16 (2.2 sec)
            • Integration tests Volto 16 (2.1 sec)
      • SonarQube compare to master (2.3 sec)
      • Pull Request (2.3 sec)
      • Declarative: Post Actions (2.6 sec)