Skip to content

Update eslint to 10 and replace glob with tinyglobby#481

Closed
nakrovati wants to merge 2 commits intoeditorconfig:mainfrom
nakrovati:chore/update-eslint-and-replace-glob
Closed

Update eslint to 10 and replace glob with tinyglobby#481
nakrovati wants to merge 2 commits intoeditorconfig:mainfrom
nakrovati:chore/update-eslint-and-replace-glob

Conversation

@nakrovati
Copy link
Copy Markdown

@nakrovati nakrovati commented Apr 8, 2026

  1. Update ESLint to 10:
    1. Remove eslint-plugin-prettier -> unused.
    2. Remove eslint-plugin-xo -> unused and deprecated.
    3. Replace the @typescript-eslint/* packages with typescript-eslint.
    4. Update prettier to 3.8.3
  2. Replace glob with tinyglobby -> the second one has fewer dependencies and is lighter.
  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run build).
  • Run npm run lint w/o errors.

Replace `glob` with `tinyglobby`—the second one is lighter and has fewer dependencies.
@nakrovati nakrovati force-pushed the chore/update-eslint-and-replace-glob branch from 601d58b to abc2f8f Compare April 8, 2026 16:49
@SunsetTechuila
Copy link
Copy Markdown
Member

I don't know why you're interested in this, but if you really want to help:

  1. Replace glob with tinyglobby -> the second one has fewer dependencies and is lighter.
  1. This isn't very useful. The tests should be rewritten so they can be bundled into a single file without depending on Node.js APIs. See: feat: make extension browser-compatible #375

Update ESLint to 10

  1. Let's not just copy the existing config. Please use this as a base: https://github.com/SunsetTechuila/image-search-bot/blob/362362c467486a7a5d3344893cce5dae05522f0b/eslint.config.js
    and tweak it according to the current settings and https://github.com/xojs/eslint-config-xo, based on your preference.
  1. Remove eslint-plugin-prettier -> it wasn't being used.
  2. Update prettier
  1. If you're willing to help with the previous points, please open a separate PR and use this config: https://github.com/SunsetTechuila/is-bun-module/blob/2c1a618f2068010a69276c90dba9b663de5bccf5/.prettierrc.json

If all of this is too much for you, that's perfectly fine. But I don't see much value in this PR in its current state.

@nakrovati
Copy link
Copy Markdown
Author

nakrovati commented Apr 8, 2026

I don't know why you're interested in this, but if you really want to help:

  1. Replace glob with tinyglobby -> the second one has fewer dependencies and is lighter.
  1. This isn't very useful. The tests should be rewritten so they can be bundled into a single file without depending on Node.js APIs. See: feat: make extension browser-compatible #375

Update ESLint to 10

  1. Let's not just copy the existing config. Please use this as a base: https://github.com/SunsetTechuila/image-search-bot/blob/362362c467486a7a5d3344893cce5dae05522f0b/eslint.config.js
    and tweak it according to the current settings and https://github.com/xojs/eslint-config-xo, based on your preference.
  1. Remove eslint-plugin-prettier -> it wasn't being used.
  2. Update prettier
  1. If you're willing to help with the previous points, please open a separate PR and use this config: https://github.com/SunsetTechuila/is-bun-module/blob/2c1a618f2068010a69276c90dba9b663de5bccf5/.prettierrc.json

If all of this is too much for you, that's perfectly fine. But I don't see much value in this PR in its current state.

Okay, then I’d better create a new PR for Eslint + Prettier, since this one has “glob” in the name.

I was wrong about eslint-config-xo - I was looking for eslint-plugin-xo, and it had been deprecated. And I switched from glob to tinyglobby just to install fewer dependencies; it’s for simple file searches like globSync('./**/*.test.js', { cwd: __dirname }) - a direct replacement: https://e18e.dev/docs/replacements/glob.html.

@nakrovati nakrovati closed this Apr 8, 2026
@SunsetTechuila
Copy link
Copy Markdown
Member

Okay, then I’d better create a new PR for Eslint + Prettier

Please split this into 2 PRs.

And I switched from glob to tinyglobby just to install fewer dependencies; it’s for simple file searches like globSync('./**/*.test.js', { cwd: __dirname }) - a direct replacement: e18e.dev/docs/replacements/glob.html.

I get it, but the goal is to drop glob completely, not just replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants