[4/8] initdata-processor: support insecure platforms#2354
Open
msanft wants to merge 3 commits into
Open
Conversation
This was referenced Apr 27, 2026
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
d983852 to
a96709b
Compare
msanft
changed the title
msanft
force-pushed
the
split/pr-2337-attestation
branch
from
35fd8b4 to
abcf97e
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
a96709b to
61b512e
Compare
burgerdev
reviewed
Apr 29, 2026
msanft
force-pushed
the
split/pr-2337-attestation
branch
from
abcf97e to
d555ab0
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
61b512e to
e3d60c2
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
e3d60c2 to
27c226a
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
27c226a to
934583d
Compare
burgerdev
requested changes
May 4, 2026
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
Unfortunately, this does not work with initdata: An attacker can launch the VM with TEE support and set HOSTDATA to their desired value, but supply an initdata file that includes Insecure. HOSTDATA is now unvalidated, but still shows in reports.
The previous version was arguably safer, but safe enough? idk.
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
934583d to
72898ef
Compare
msanft
changed the title
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
72898ef to
f2897e6
Compare
msanft
force-pushed
the
split/pr-2337-runtime-nodeinstaller
branch
2 times, most recently
from
dda6dc2 to
d1e13e3
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
2 times, most recently
from
91b1df7 to
db7cd22
Compare
msanft
force-pushed
the
split/pr-2337-runtime-nodeinstaller
branch
from
d1e13e3 to
70e5da4
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
db7cd22 to
a8f6eb6
Compare
msanft
force-pushed
the
split/pr-2337-runtime-nodeinstaller
branch
2 times, most recently
from
056e110 to
9f047ca
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
2 times, most recently
from
fd0d094 to
bbf67f4
Compare
msanft
force-pushed
the
split/pr-2337-runtime-nodeinstaller
branch
2 times, most recently
from
5fa6e62 to
6c99247
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
bbf67f4 to
9da6471
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
2 times, most recently
from
aa5ba51 to
4e3d618
Compare
msanft
force-pushed
the
split/pr-2337-initdata
branch
from
4e3d618 to
c168265
Compare
charludo
approved these changes
May 19, 2026
Collaborator
charludo
left a comment
charludo
left a comment
There was a problem hiding this comment.
I just have one nit, LGTM otherwise.
| log.Printf("hostdata write error: %v", err) | ||
| } | ||
| }) | ||
| return http.ListenAndServe(insecure.HostdataAddr, mux) |
Collaborator
There was a problem hiding this comment.
Should probably add a http.Server.Shutdown hook, just for cleanliness' sake, since this currently can never exit cleanly, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2337 as part of a stacked review series.
Depends on: #2353
This PR teaches the initdata-processor how to operate on insecure platforms: