Fix retry_statuses dropped because list.append() returns None#93
Open
mark124 wants to merge 1 commit into
Open
Fix retry_statuses dropped because list.append() returns None#93mark124 wants to merge 1 commit into
mark124 wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EdFiAPI.get_retry_client()builds its retry-status set as:list.append()returnsNone, sostatuses=NonereachesExponentialRetryand the configuredretry_statuses(429/500/501/503/504) are dropped - a 429 rate-limit is never retried. It also mutatesconfig['connection']['retry_statuses']in place, appending another401on every call.Fix
Build a fresh list - a copy of the configured statuses plus 401:
One line; fixes both the dropped statuses and the in-place mutation. (The edit also adds a trailing newline at end of file - the second line in the diff.)
Verified
get_retry_client()now retries{429, 500, 501, 503, 504, 401}, and the config list is unchanged across repeated calls.Addresses the retry-client bug noted in the "Related bug (compounding)" section of #92.