This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Add guard for unavailable URLSearchParams#261
Open
simonihmig wants to merge 1 commit intoecsyjs:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a better guard for
URLSearchParamseventually not being defined.I ran into this when running the code in node (context: FastBoot, the Ember.js SSR solution, runs a client-side SPA in node, and has a
windowglobal defined - for whatever reason - but not any of the other browser APIs). But IE also does not supportURLSearchParams, so this is good to have in general I think!