Skip to content

fix(storefront): Refresh passport token before loading checkout app when near expiry #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leomp12 merged 3 commits into from
Aug 2, 2026
+19 −1
Merged

fix(storefront): Refresh passport token before loading checkout app when near expiry #785

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c91a669
fix(storefront): Refresh passport token before loading checkout app w…
vitorrgg Jul 24, 2026
3c530e5
fix(storefront): Update checkout app to retry customer fetch on token…
leomp12 Aug 2, 2026
3889a3c
chore(storefront): Simplify checkout token refresh gate
leomp12 Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/storefront/src/lib/scripts/vbeta-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ if (!import.meta.env.SSR) {
const appScript = document.createElement('script');
appScript.src = src
|| (window as any)._appScriptSrc
|| 'https://cdn.jsdelivr.net/npm/@ecomplus/storefront-app@2.0.0-beta.227/dist/lib/js/app.js';
|| 'https://cdn.jsdelivr.net/npm/@ecomplus/storefront-app@2.0.0-beta.228/dist/lib/js/app.js';
appScript.onload = () => {
setTimeout(() => {
watchAppRoutes();
Expand Down Expand Up @@ -337,6 +337,24 @@ if (!import.meta.env.SSR) {
console.error(err);
loadAppScript();
});
} else if (session.auth && !isAuthenticated.value) {
// Stored passport token is stale: wait for Firebase auth to renew it
// before app.js starts fetching with it
const waitingTokenRefresh = initializingAuth.then(async (firebaseAuth) => {
await firebaseAuth.authStateReady();
if (isAuthReady.value) return;
await new Promise<void>((resolve) => {
const unwatch = watch(isAuthReady, (ready) => {
if (!ready) return;
unwatch();
resolve();
});
});
});
Promise.race([
waitingTokenRefresh.catch(console.error),
new Promise((resolve) => { setTimeout(resolve, 10000); }),
]).then(() => loadAppScript());
} else {
loadAppScript();
}
Expand Down