Skip to content

Repair and execute remaining Swing tests #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptziegler merged 5 commits into from
May 16, 2026
Merged

Repair and execute remaining Swing tests #1514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
452f2ce
Adapt GridBagLayoutTest to changed copy-paste functionality
ptziegler May 15, 2026
0a69faa
Enable previously disabled `GridBagLayoutSelectionActionsTest` test
ptziegler May 15, 2026
c3cd821
Migrate Swing Property tests to text blocks
ptziegler May 15, 2026
3c0aa71
Adapt TabOrderPropertyValueTest to new behavior of tab ordering
ptziegler May 15, 2026
5d92168
Repair and execute disabled JFrameTopBoundsTest
ptziegler May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...g/eclipse/wb/tests/designer/swing/model/layout/gbl/GridBagLayoutSelectionActionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011, 2025 Google, Inc. and others.
* Copyright (c) 2011, 2026 Google, Inc. and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License 2.0 which is available at
Expand All @@ -19,7 +19,6 @@

import org.eclipse.jface.action.IAction;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.util.ArrayList;
Expand All @@ -36,7 +35,6 @@ public class GridBagLayoutSelectionActionsTest extends AbstractGridBagLayoutTest
// Tests
//
////////////////////////////////////////////////////////////////////////////
@Disabled
@Test
public void test_selectionActions() throws Exception {
ContainerInfo panel = parseContainer("""
Expand Down
12 changes: 5 additions & 7 deletions ....wb.tests/src/org/eclipse/wb/tests/designer/swing/model/layout/gbl/GridBagLayoutTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.awt.Component;
Expand Down Expand Up @@ -2355,7 +2354,6 @@ public Test() {
/**
* We should not change alignments when paste existing panel.
*/
@Disabled
@Test
public void test_clipboard_disableAutoAlignment() throws Exception {
ContainerInfo panel = parseContainer("""
Expand Down Expand Up @@ -2416,28 +2414,28 @@ public Test() {
}
}
{
JPanel panel = new JPanel();
add(panel);
JPanel inner = new JPanel();
add(inner);
GridBagLayout gridBagLayout = new GridBagLayout();
gridBagLayout.columnWidths = new int[]{0, 0, 0};
gridBagLayout.rowHeights = new int[]{0, 0};
gridBagLayout.columnWeights = new double[]{0.0, 0.0, Double.MIN_VALUE};
gridBagLayout.rowWeights = new double[]{0.0, Double.MIN_VALUE};
panel.setLayout(gridBagLayout);
inner.setLayout(gridBagLayout);
{
JLabel label = new JLabel();
GridBagConstraints gbc = new GridBagConstraints();
gbc.insets = new Insets(0, 0, 0, 5);
gbc.gridx = 0;
gbc.gridy = 0;
panel.add(label, gbc);
inner.add(label, gbc);
}
{
JTextField textField = new JTextField();
GridBagConstraints gbc = new GridBagConstraints();
gbc.gridx = 1;
gbc.gridy = 0;
panel.add(textField, gbc);
inner.add(textField, gbc);
}
}
}
Expand Down
Loading
Loading