Skip to content

Simplify GC.drawImage() test with applied transformation #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Apr 24, 2026
+14 −15
Merged

Simplify GC.drawImage() test with applied transformation #3268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions ...e.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_GC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,14 @@
@SuppressWarnings("restriction")
public class Test_org_eclipse_swt_graphics_GC {

private static final int IMAGE_SIZE = 200;

@BeforeEach
public void setUp() {
display = Display.getDefault();
shell = new Shell(display);
shell.setBounds(0,30,240,290);
image = new Image(display, 200, 200);
image = new Image(display, IMAGE_SIZE, IMAGE_SIZE);
gc = new GC(image);
}

Expand Down Expand Up @@ -408,27 +410,24 @@ public void test_drawImageLorg_eclipse_swt_graphics_ImageIIII_withTransform() th
try (InputStream is = getClass().getResourceAsStream("collapseall.svg")) {
image = new Image(Display.getDefault(), is);
}

Image referenceImage = new Image(display, IMAGE_SIZE, IMAGE_SIZE);
GC referenceImageGC = new GC(referenceImage);
referenceImageGC.drawImage(image, 0, 0, 4, 4);
referenceImageGC.drawImage(image, 10, 10, 4, 4);
ImageData referenceImageData = referenceImage.getImageData(DPIUtil.getDeviceZoom());
referenceImage.dispose();

Transform transform = new Transform(display, 2, 0, 0, 2, 0, 0);
gc.setTransform(transform);
gc.drawImage(image, 0, 0, 2, 2);
ImageData resultImageDataWithTransform = getImageDataFromGC(gc, 0, 0, 4, 4);

gc.setTransform(null);
gc.drawImage(image, 10, 10, 4, 4);
ImageData resultImageDataWithoutTransform = getImageDataFromGC(gc, 10, 10, 4, 4);

ImageDataTestHelper.assertImageDataEqual(resultImageDataWithoutTransform, resultImageDataWithoutTransform, resultImageDataWithTransform);

image.dispose();
transform.dispose();
}
ImageData imageData = this.image.getImageData(DPIUtil.getDeviceZoom());

private ImageData getImageDataFromGC(GC gc, int x, int y, int width, int height) {
Image extractionImage = new Image(display, width, height);
gc.copyArea(extractionImage, x, y);
ImageData resultImageData = extractionImage.getImageData();
extractionImage.dispose();
return resultImageData;
ImageDataTestHelper.assertImageDataEqual(referenceImageData, imageData, referenceImageData);
image.dispose();
}

@Test
Expand Down
Loading