Skip to content

Migrate 6 OldSchoolEffect examples to GraphicsExample#3241

Merged
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:migrate-effects-phase2
Apr 17, 2026
Merged

Migrate 6 OldSchoolEffect examples to GraphicsExample#3241
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:migrate-effects-phase2

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 16, 2026

Summary

Migrates 6 image-based effects from SWT-OldSchoolEffect to the SWT GraphicsExample framework:

Effect Source Tab Class Image
Block Effect rayfilter/BlockEffect.java BlockEffectTab flower.jpg
Twirl Effect rayfilter/TwirlEffect.java TwirlEffectTab flower.jpg
Sine Wave sinewave/SineWave.java SineWaveTab tuxblackbg.png
Sky sky2/Sky2.java SkyTab DEMO2.png
Unlimited Balls unlimitedballs/UnlimitedBalls.java UnlimitedBallsTab ball.gif
Warp warp/Warp.java WarpTab texture.png

Migration Checklist

  • No Color disposal (modern SWT)
  • Use simple new Color(r, g, b) constructor
  • Dispose Images in dispose() and before recreation
  • Dispose GC after use
  • No compiler errors or warnings (build succeeds)
  • $NON-NLS-1$ markers on resource string keys
  • Proper EPL-2.0 copyright header with original author credit
  • Category = "Misc"
  • Localized strings in examples_graphics.properties
  • Inner classes for helpers where needed (SinEffect in SineWaveTab)

Build Verification

mvn clean verify -Dnative=gtk.linux.x86_64 -DskipTests

BUILD SUCCESS (no new warnings introduced)

Contributes to #3189

🤖 Generated with Claude Code

Migrates 6 image-based effects from SWT-OldSchoolEffect:
- Block Effect (rayfilter/BlockEffect.java + flower.jpg)
- Twirl Effect (rayfilter/TwirlEffect.java + flower.jpg)
- Sine Wave (sinewave/SineWave.java + tuxblackbg.png)
- Sky (sky2/Sky2.java + DEMO2.png)
- Unlimited Balls (unlimitedballs/UnlimitedBalls.java + ball.gif)
- Warp (warp/Warp.java + texture.png)

Contributes to eclipse-platform#3189

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

  182 files  ±0    182 suites  ±0   24m 18s ⏱️ -26s
4 701 tests ±0  4 680 ✅ ±0   21 💤 ±0  0 ❌ ±0 
6 704 runs  ±0  6 546 ✅ ±0  158 💤 ±0  0 ❌ ±0 

Results for commit 2a6f50e. ± Comparison against base commit dbac219.

@vogella vogella merged commit f1bf0d3 into eclipse-platform:master Apr 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant