Document how to check which bundles a test run actually uses - #2407
Closed
vogella wants to merge 1 commit into
Closed
Document how to check which bundles a test run actually uses#2407vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
Building the changed bundle alongside its test bundle covers that one bundle, but every other bundle still comes from the target platform as a released artifact, so a change reached only indirectly is not under test. Mention -am for building the upstream closure from source, and describe how to tell from config.ini whether the harness installed the local build or the released bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md already explains that a changed production bundle has to be listed in
-plnext to its test bundle. That covers the listed bundle, but every other bundle still comes from the target platform as a released artifact, so a change that the test bundle only reaches indirectly is silently not under test. This adds-amfor building the whole upstream closure from source, following the same pattern the SWT repository documents.It also describes how to verify the outcome:
target/work/configuration/config.ininames the bundles the harness installed, so a path under the localtarget/directory means your build was used and one under~/.m2/repository/p2/means the released bundle was. That check is worth doing before trusting a green or a red run, because only the test bundle itself is mapped to its class folders viadev.properties.