Add unit tests for DependencyLoopFinder cycle detection - #2405
Open
vogella wants to merge 1 commit into
Open
Conversation
Cover the cases the dependency-cycle finder behind the MANIFEST.MF editor's "Look for cycles in the dependency graph" action handles today: no cycle, a direct mutual dependency, a three-bundle cycle, two separate cycles through the root, independence from the order in which the root declares its dependencies, and a cycle beside the root that must not hide the cycle through it. The tests build dummy target bundles and resolve them through PluginRegistry, exercising the production code path. Registered in AllPDECoreTests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency-cycle finder behind the MANIFEST.MF editor's "Look for cycles in the dependency graph" action had no test coverage. These tests cover what it handles today: no cycle, a direct mutual dependency, a three-bundle cycle, two separate cycles through the root, independence from the order in which the root declares its dependencies, and a cycle beside the root that must not hide the cycle through it.
The graph for each test is built from dummy target bundles that are resolved through PluginRegistry, so the tests exercise the real production code path rather than a stand-in. All of them pass against the current implementation.