Change expected message in test #4922#5005
Merged
jjohnstn merged 1 commit intoApr 18, 2026
Merged
Conversation
Contributor
|
OK, thank you, I'll have to check where the other fails are coming from in that case. |
Contributor
Author
|
@trancexpress wait, I only checked jdt core. The other one you mentioned must also come from my change. Let me fix it too :-) |
Contributor
Author
|
The failing test is unrelated and will be fixed once #5007 is merged |
In test org.eclipse.jdt.core.tests.model.ClasspathTests.testBug539998() Contributes to eclipse-jdt#4992
akurtakov
force-pushed
the
change_expected_message_test
branch
from
e35e7c3 to
4850a0e
Compare
jjohnstn
approved these changes
Apr 18, 2026
Contributor
jjohnstn
left a comment
jjohnstn
left a comment
There was a problem hiding this comment.
Test verified to pass in PR build output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4992 (comment)
@trancexpress I only found 1 failing test because of #4922 in the nightly builds and I am currently running
org.eclipse.jdt.core.tests.model.AllJavaModelTestslocally to see if something else broke. I'll undraft this PR as soon as the tests run green locally.