typo fix: paramater --> parameter#2326
Open
GerHobbelt wants to merge 1 commit intoeclipse-iceoryx:mainfrom
Open
typo fix: paramater --> parameter#2326GerHobbelt wants to merge 1 commit intoeclipse-iceoryx:mainfrom
GerHobbelt wants to merge 1 commit intoeclipse-iceoryx:mainfrom
Conversation
Member
|
@GerHobbelt since we are an Eclipse project, you need to sign the ECA. Without that, we can not merge the PR. Also, since iceoryx is used in a safety critical environment we have to follow rules for traceability. One of the rules is that the commit message must have the issue number of the related issue at the front. Usually, we have to create an issue first before we create commits but for such small changes you can use #2305. Can you please change the commit message to
And also add
to the bottom of the PR description |
Member
|
@GerHobbelt are you planing to continue on this? If not, I would fix the typo with one of my next PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
As it says on the tin. Just a very minor English language tidbit.
Pre-Review Checklist for the PR Author