[rec_core] Record ecalhdf5 v6, respecting topic-id.#1884
Draft
KerstinKeller wants to merge 2 commits intomasterfrom
Draft
[rec_core] Record ecalhdf5 v6, respecting topic-id.#1884KerstinKeller wants to merge 2 commits intomasterfrom
KerstinKeller wants to merge 2 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| void EcalRecImpl::EcalMessageReceived(const eCAL::Registration::STopicId& topic_id_, const eCAL::SReceiveCallbackData& data_) | ||
| void EcalRecImpl::EcalMessageReceived(const Registration::STopicId& topic_id_, const SDataTypeInformation& datatype_info_, const SReceiveCallbackData& callback_data_) |
Contributor
There was a problem hiding this comment.
warning: parameter 'datatype_info_' is unused [misc-unused-parameters]
Suggested change
| void EcalRecImpl::EcalMessageReceived(const Registration::STopicId& topic_id_, const SDataTypeInformation& datatype_info_, const SReceiveCallbackData& callback_data_) | |
| void EcalRecImpl::EcalMessageReceived(const Registration::STopicId& topic_id_, const SDataTypeInformation& /*datatype_info_*/, const SReceiveCallbackData& callback_data_) |
| auto system_receive_time = std::chrono::steady_clock::now(); | ||
|
|
||
| std::shared_ptr<Frame> frame = std::make_shared<Frame>(&data_, topic_id_.topic_name, ecal_receive_time, system_receive_time); | ||
| std::shared_ptr<Frame> frame = std::make_shared<Frame>(callback_data_, topic_id_, ecal_receive_time, system_receive_time); |
Contributor
There was a problem hiding this comment.
warning: variable 'frame' of type 'std::shared_ptr' can be declared 'const' [misc-const-correctness]
Suggested change
| std::shared_ptr<Frame> frame = std::make_shared<Frame>(callback_data_, topic_id_, ecal_receive_time, system_receive_time); | |
| std::shared_ptr<Frame> const frame = std::make_shared<Frame>(callback_data_, topic_id_, ecal_receive_time, system_receive_time); |
| data_.reserve(callback_data->size); | ||
| data_.assign((char*)callback_data->buf, (char*)callback_data->buf + callback_data->size); | ||
| data_.reserve(callback_data.size); | ||
| data_.assign((char*)callback_data.buf, (char*)callback_data.buf + callback_data.size); |
Contributor
There was a problem hiding this comment.
warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]
data_.assign((char*)callback_data.buf, (char*)callback_data.buf + callback_data.size);
^| data_.reserve(callback_data->size); | ||
| data_.assign((char*)callback_data->buf, (char*)callback_data->buf + callback_data->size); | ||
| data_.reserve(callback_data.size); | ||
| data_.assign((char*)callback_data.buf, (char*)callback_data.buf + callback_data.size); |
Contributor
There was a problem hiding this comment.
warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]
data_.assign((char*)callback_data.buf, (char*)callback_data.buf + callback_data.size);
^| for (const auto& topic : topic_info_map_to_set) | ||
| { | ||
| // convert from eCAL core types to eCAL measurement types before writing to the measurement. | ||
| eh5::SChannel channel{ topic.first.topic_name, topic.first.topic_id.entity_id }; |
Contributor
There was a problem hiding this comment.
warning: variable 'channel' of type 'eh5::SChannel' (aka 'eCAL::experimental::measurement::base::Channel') can be declared 'const' [misc-const-correctness]
Suggested change
| eh5::SChannel channel{ topic.first.topic_name, topic.first.topic_id.entity_id }; | |
| eh5::SChannel const channel{ topic.first.topic_name, topic.first.topic_id.entity_id }; |
| topic_info_snapshot.insert({ publisher_id , std::move(datatype_info) }); | ||
| } | ||
|
|
||
| std::lock_guard<decltype(monitoring_mutex_)> monitoring_lock(monitoring_mutex_); |
Contributor
There was a problem hiding this comment.
warning: variable 'monitoring_lock' of type 'std::lock_guard<decltype(this->monitoring_mutex_)>' (aka 'lock_guardstd::mutex') can be declared 'const' [misc-const-correctness]
Suggested change
| std::lock_guard<decltype(monitoring_mutex_)> monitoring_lock(monitoring_mutex_); | |
| std::lock_guard<decltype(monitoring_mutex_)> const monitoring_lock(monitoring_mutex_); |
KerstinKeller
force-pushed
the
feature/record-with-topicid
branch
3 times, most recently
from
ae58db3 to
af31e40
Compare
KerstinKeller
force-pushed
the
feature/record-with-topicid
branch
from
2a582d5 to
47c77d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to record both Publisher and its unque ID within the measurement.
This PR aims to do that.
We do not need to do any kind of quality computation any longer.
Later on, we might be able to play back only topics published by a given publisher.
Currently, it builds, however, nothing is recorded. Need to review why it breaks the recording.