[DO NOT MERGE] fix: Handle "NULL" string as unconfigured OAuth identity provider#995
Open
ibuziuk wants to merge 2 commits intoeclipse-che:mainfrom
Open
[DO NOT MERGE] fix: Handle "NULL" string as unconfigured OAuth identity provider#995ibuziuk wants to merge 2 commits intoeclipse-che:mainfrom
ibuziuk wants to merge 2 commits intoeclipse-che:mainfrom
Conversation
Treat the string "NULL" as equivalent to an unconfigured OAuth identity provider. This fixes the case where property placeholder defaults result in "NULL" being passed instead of null or empty string, which previously caused incorrect service account selection when initializing projects. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
ibuziuk
commented
Apr 7, 2026
| Map<String, String> namespaceAnnotationsEvaluated = | ||
| evaluateAnnotationPlaceholders(resolutionCtx); | ||
|
|
||
| // Use Che server SA when initWithCheServerSa is true and OAuth is configured. |
Member
Author
There was a problem hiding this comment.
Suggested change
| // Use Che server SA when initWithCheServerSa is true and OAuth is configured. | |
| // Use Che server SA when initWithCheServerSa is true and OAuth is not configured. |
Member
Author
|
/retest |
ibuziuk
changed the title
|
@ibuziuk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Treat the string "NULL" as equivalent to an unconfigured OAuth identity provider. This fixes the case where property placeholder defaults result in "NULL" being passed instead of null or empty string, which previously caused incorrect service account selection when initializing projects.
https://redhat.atlassian.net/browse/CRW-10656
related property -
che-server/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/multiuser.properties
Line 76 in ff937ca
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.