Bump dependencies - #330
Conversation
| InvalidLength, | ||
| InvalidLength(usize), | ||
| InvalidLastSymbol(usize, u8), | ||
| InvalidPadding, |
| (None, _) => { | ||
| (Err(_), _) => { | ||
| return Err(error::Format::DeserializationError( | ||
| "deserialization error: unary operation is empty".to_string(), |
There was a problem hiding this comment.
Not sure about that error message
| (Ok(op_binary::Kind::TryOr), None) => Op::Binary(Binary::TryOr), | ||
| (Err(_), _) => { | ||
| return Err(error::Format::DeserializationError( | ||
| "deserialization error: binary operation is empty".to_string(), |
349847c to
217a244
Compare
| proc-macro2 = "1" | ||
| quote = "1.0.14" | ||
| syn = { version = "1.0.85", features = ["full", "extra-traits"] } | ||
| syn = { version = "2.0.117", default-features = false } |
There was a problem hiding this comment.
syn 3 was released recently, I guess we could skip version 2
|
@divarvel any interest in this? |
|
Hi @avandecreme Thanks for the PR! The blocker in the description looks like it has cleared since this was opened in May: ed25519-dalek 3.0.0 went stable on 2026-07-06 and takes rand_core ^0.10, so rand/rand_core are no longer pinned back by it. For what it's worth, the rest of the stack this PR would need has landed as stable releases too, all after this PR was opened:
That may also unblock #312, its description notes there was no final RustCrypto release at the time, and that is no longer the case. A downstream data point in case it helps prioritise: we build services on biscuit-auth, and because our own code shares SigningKey / PublicKey types with the library across an API boundary, we can't dual-version the crypto stack. So biscuit-auth 6.0.0's requirements transitively hold our whole workspace at ed25519-dalek 2, p256 0.13, rand 0.8, rand_core 0.6 and getrandom 0.2, we attempted the upgrade this week and had to back all of it out, while every other dependency moved. Hi @divarvel , when you get a chance, could you please give a review to this PR? Thank you in advance! |
2 participants
I couldn't bump
rand_coreandrandbecause they are tied to the version used byed25519-dalek.