Add support for active high CS#382
Open
andreasWallner wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few custom devices that use active-high CS. I only looked after an initial implementation and then saw #86 and #258.
After checking those I saw that also the newer PR (#258) is too old to cover some of the current API, so I stuck with my implementation but took the API feedback from #258 on board and implemented the setting as an iterable over CS slot numbers.
I verified the changes with some devices here, as well as via logic analyzer and the added testcase.
I also fixed some forgotten
fs in f-strings and a documentation typo.Exchange test:
Read test:
Write test:
Mixed test:
