Skip to content

Add tests to check that theme argument works in check_model()#444

Merged
strengejacke merged 5 commits into
mainfrom
check_model_theme_tests
Jun 29, 2026
Merged

Add tests to check that theme argument works in check_model()#444
strengejacke merged 5 commits into
mainfrom
check_model_theme_tests

Conversation

@strengejacke

Copy link
Copy Markdown
Member

Updated test (easystats/performance#869)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the package version to 0.14.0.10 and introduces a new test suite in tests/testthat/test-check_model_theme.R to verify the theme argument behavior in performance::check_model(). Feedback on the changes suggests adding a check to ensure the vdiffr package is installed before running these tests, preventing unexpected failures in environments where it is missing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@@ -0,0 +1,201 @@
skip_on_cran()
skip_if_not_installed("performance")
skip_if_not_installed("ggplot2")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test file uses vdiffr::expect_doppelganger inside the helper function expect_doppelganger_with_seed, but it does not check if the vdiffr package is installed. If vdiffr is missing in the testing environment, the tests will fail with an error instead of being gracefully skipped. Please add skip_if_not_installed("vdiffr") at the top of the file.

skip_if_not_installed("ggplot2")
skip_if_not_installed("vdiffr")

@strengejacke strengejacke merged commit 9bbd818 into main Jun 29, 2026
10 of 27 checks passed
@strengejacke strengejacke deleted the check_model_theme_tests branch June 29, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant