Skip to content

feat(evo-marko): alert & confirm dialog#622

Open
LuLaValva wants to merge 5 commits intomainfrom
alert-confirm-dialog
Open

feat(evo-marko): alert & confirm dialog#622
LuLaValva wants to merge 5 commits intomainfrom
alert-confirm-dialog

Conversation

@LuLaValva
Copy link
Copy Markdown
Member

Description

  • Add <evo-alert-dialog> and <evo-confirm-dialog>

Notes

  • The real question here is should these be separate components? Since they are so common and there is slightly different behavior for each of them I think there's value in keeping them apart, but this is up for debate.
  • I also modified some AI instructions to make sure code follows best practices moving forward

Screenshots

image image

Copilot AI review requested due to automatic review settings April 14, 2026 02:12
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

🦋 Changeset detected

Latest commit: 23381d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@evo-web/marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new Evo Marko dialog variants for common “must acknowledge” and “confirm vs cancel” flows, with Storybook docs/examples and Vitest SSR/browser coverage.

Changes:

  • Introduce new <evo-alert-dialog> and <evo-confirm-dialog> components built on native <dialog> + @ebay/skin/dialog.
  • Add Storybook stories, READMEs, and usage examples for both components.
  • Add SSR snapshot tests and browser interaction/a11y tests; tighten Storybook argTypes for evo-dialog button a11yText.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/evo-marko/src/tags/evo-dialog/dialog.stories.ts Improves Storybook argTypes to require/describe a11yText for header icon buttons.
packages/evo-marko/src/tags/evo-confirm-dialog/index.marko Implements confirm dialog behavior (modal open/close, header/content/footer actions).
packages/evo-marko/src/tags/evo-confirm-dialog/style.ts Pulls in Skin dialog styling for the new component.
packages/evo-marko/src/tags/evo-confirm-dialog/examples/default.marko Adds a runnable example demonstrating open binding + slots.
packages/evo-marko/src/tags/evo-confirm-dialog/confirm-dialog.stories.ts Adds Storybook entry + controls/docs wiring.
packages/evo-marko/src/tags/evo-confirm-dialog/README.md Documents component purpose and links to Storybook/examples.
packages/evo-marko/src/tags/evo-confirm-dialog/test/test.server.ts Adds SSR snapshot coverage for closed/open states.
packages/evo-marko/src/tags/evo-confirm-dialog/test/test.browser.ts Adds browser tests for structure, attributes, and interactions (click/Escape).
packages/evo-marko/src/tags/evo-alert-dialog/index.marko Implements alert dialog behavior (acknowledge-only dismissal).
packages/evo-marko/src/tags/evo-alert-dialog/style.ts Pulls in Skin dialog styling for the new component.
packages/evo-marko/src/tags/evo-alert-dialog/examples/default.marko Adds a runnable example demonstrating open binding + slots.
packages/evo-marko/src/tags/evo-alert-dialog/alert-dialog.stories.ts Adds Storybook entry + controls/docs wiring.
packages/evo-marko/src/tags/evo-alert-dialog/README.md Documents component purpose and links to Storybook/examples.
packages/evo-marko/src/tags/evo-alert-dialog/test/test.server.ts Adds SSR snapshot coverage for closed/open states.
packages/evo-marko/src/tags/evo-alert-dialog/test/test.browser.ts Adds browser tests for structure, attributes, and interactions (click/Escape).
CLAUDE.md Updates AI guidance around Marko 6 tag variable locality.
.claude/skills/evo-migrate-marko/SKILL.md Updates migration guidance to prefer Marko.HTML.* element types.

LuLaValva and others added 2 commits April 14, 2026 11:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! minor things to iron out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants