Open
Conversation
🦋 Changeset detectedLatest commit: 23381d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Evo Marko dialog variants for common “must acknowledge” and “confirm vs cancel” flows, with Storybook docs/examples and Vitest SSR/browser coverage.
Changes:
- Introduce new
<evo-alert-dialog>and<evo-confirm-dialog>components built on native<dialog>+@ebay/skin/dialog. - Add Storybook stories, READMEs, and usage examples for both components.
- Add SSR snapshot tests and browser interaction/a11y tests; tighten Storybook argTypes for
evo-dialogbutton a11yText.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evo-marko/src/tags/evo-dialog/dialog.stories.ts | Improves Storybook argTypes to require/describe a11yText for header icon buttons. |
| packages/evo-marko/src/tags/evo-confirm-dialog/index.marko | Implements confirm dialog behavior (modal open/close, header/content/footer actions). |
| packages/evo-marko/src/tags/evo-confirm-dialog/style.ts | Pulls in Skin dialog styling for the new component. |
| packages/evo-marko/src/tags/evo-confirm-dialog/examples/default.marko | Adds a runnable example demonstrating open binding + slots. |
| packages/evo-marko/src/tags/evo-confirm-dialog/confirm-dialog.stories.ts | Adds Storybook entry + controls/docs wiring. |
| packages/evo-marko/src/tags/evo-confirm-dialog/README.md | Documents component purpose and links to Storybook/examples. |
| packages/evo-marko/src/tags/evo-confirm-dialog/test/test.server.ts | Adds SSR snapshot coverage for closed/open states. |
| packages/evo-marko/src/tags/evo-confirm-dialog/test/test.browser.ts | Adds browser tests for structure, attributes, and interactions (click/Escape). |
| packages/evo-marko/src/tags/evo-alert-dialog/index.marko | Implements alert dialog behavior (acknowledge-only dismissal). |
| packages/evo-marko/src/tags/evo-alert-dialog/style.ts | Pulls in Skin dialog styling for the new component. |
| packages/evo-marko/src/tags/evo-alert-dialog/examples/default.marko | Adds a runnable example demonstrating open binding + slots. |
| packages/evo-marko/src/tags/evo-alert-dialog/alert-dialog.stories.ts | Adds Storybook entry + controls/docs wiring. |
| packages/evo-marko/src/tags/evo-alert-dialog/README.md | Documents component purpose and links to Storybook/examples. |
| packages/evo-marko/src/tags/evo-alert-dialog/test/test.server.ts | Adds SSR snapshot coverage for closed/open states. |
| packages/evo-marko/src/tags/evo-alert-dialog/test/test.browser.ts | Adds browser tests for structure, attributes, and interactions (click/Escape). |
| CLAUDE.md | Updates AI guidance around Marko 6 tag variable locality. |
| .claude/skills/evo-migrate-marko/SKILL.md | Updates migration guidance to prefer Marko.HTML.* element types. |
packages/evo-marko/src/tags/evo-confirm-dialog/test/test.browser.ts
Outdated
Show resolved
Hide resolved
packages/evo-marko/src/tags/evo-alert-dialog/test/test.browser.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
saiponnada
reviewed
Apr 14, 2026
Contributor
saiponnada
left a comment
There was a problem hiding this comment.
LGTM! minor things to iron out.
packages/evo-marko/src/tags/evo-confirm-dialog/confirm-dialog.stories.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<evo-alert-dialog>and<evo-confirm-dialog>Notes
Screenshots