Add metrics for baseline resync#266
Conversation
2014fec to
00304e9
Compare
847cef6 to
118c960
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 63.15% 61.12% -2.04%
==========================================
Files 32 33 +1
Lines 1900 2822 +922
Branches 204 332 +128
==========================================
+ Hits 1200 1725 +525
- Misses 600 921 +321
- Partials 100 176 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c568bec to
4256eea
Compare
xiaoxichen
left a comment
There was a problem hiding this comment.
a few suggestion for metrics.
Q: What is the reason to introduce metrics in testing code ?
It is convenient for us to troubleshoot the http/metrics problems in the local dev environment if needed(disabled by default). |
DonerSnapshotMetrics is in memory; ReceiverSnapshotMetrics persists the progress.
Add statistic information to the pg meta/shard meta message.
Add metrics to track the progress.
Currently, use
DefaultBucketfor histogram metrics. We can refine it after the BR performance test.