Skip to content

Address metrics visibility feedback - separate repository and dependent class tracking - #28

Closed
e4c5 with Copilot wants to merge 1 commit into
christmasfrom
copilot/sub-pr-27
Closed

e4c5 with Copilot wants to merge 1 commit into
christmasfrom
copilot/sub-pr-27

Conversation

Copilot AI commented Jan 3, 2026 •

Copy link
Copy Markdown
Contributor

Review feedback indicated that changing "Dependent Files modified" to "Repository files modified" removed visibility of dependent class modifications, which are tracked separately.

Changes

The feedback was already addressed in commit e937356:

  • Added repositoriesModified field to track repository files separately from dependent classes
  • Updated dependentClassesModified javadoc to clarify it excludes repositories
  • Modified output labels in printSummary():
    • "Repository files modified" → total.repositoriesModified
    • "Dependent classes modified" → total.dependentClassesModified (retained)

Both metrics now display independently in the summary output:

out.printf("Repository files modified:   %d%n", total.repositoriesModified);
// ... other metrics ...
out.printf("Dependent classes modified:  %d%n", total.dependentClassesModified);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI assigned Copilot and e4c5 Jan 3, 2026
Copilot AI mentioned this pull request Jan 3, 2026
@coderabbitai

coderabbitai Bot commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Address feedback from review on Christmas pull request Address metrics visibility feedback - separate repository and dependent class tracking Jan 3, 2026
Copilot AI requested a review from e4c5 January 3, 2026 05:55
@e4c5

e4c5 commented Jan 3, 2026

Copy link
Copy Markdown
Owner

@copilot So in other words no code changes are needed?

Copilot AI commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot So in other words no code changes are needed?

Correct, no code changes are needed. The fix was already implemented in commit e937356 (before this PR was created). The code currently has:

  • repositoriesModified field (line 49) for tracking repository files
  • dependentClassesModified field (line 53) for tracking dependent classes

Both metrics display separately in printSummary():

  • Line 191: "Repository files modified" → total.repositoriesModified
  • Line 195: "Dependent classes modified" → total.dependentClassesModified

This PR was created to verify the feedback was addressed, and it has been.

@e4c5 e4c5 closed this Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants