feat: validate aws:CalledVia condition key service values#262
Open
raajheshkannaa wants to merge 2 commits intoduo-labs:mainfrom
Open
feat: validate aws:CalledVia condition key service values#262raajheshkannaa wants to merge 2 commits intoduo-labs:mainfrom
raajheshkannaa wants to merge 2 commits intoduo-labs:mainfrom
Conversation
Check that services referenced in aws:CalledVia, aws:CalledViaFirst, and aws:CalledViaLast conditions are in the documented list of supported services. Fixes duo-labs#84
…dead code - Add databrew.amazonaws.com, macie.amazonaws.com, s3.amazonaws.com to CALLEDVIA_SUPPORTED_SERVICES - Switch list to set for O(1) membership checks - Add .lower() on value before checking against the (all-lowercase) set - Remove unused `import re` and unused `operator` variable extraction - Update tests: fix stale invalid-service example (s3 -> ec2), add new services to all_supported test
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84
Summary
aws:CalledVia,aws:CalledViaFirst, andaws:CalledViaLastconditionsINVALID_CALLEDVIA_SERVICE(severity: MEDIUM)Supported services
athena,cloudformation,databrew,dynamodb,kms,macie,ram,rolesanywhere,s3(all.amazonaws.com)Test plan