Skip to content

Add multiprice recipe #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GoZOo wants to merge 6 commits into from
Closed

Add multiprice recipe #56

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1758dab
Add multiprice recipe
GoZOo Jan 27, 2017
94a8630
Add language manager as DependencyInjection
GoZOo Jan 28, 2017
a27a215
Miss switching resolver service arguments to language_manager
GoZOo Jan 28, 2017
c75750c
language module has to be enabled and french and japanese languages s…
GoZOo Jan 28, 2017
f6cc9ea
Replace multiprice field by 1 field by currency
GoZOo Jan 28, 2017
c8641ba
Remove line from end of file
GoZOo Jan 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions v2/recipes/multiprice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,23 @@ use Drupal\commerce_price\Resolver\PriceResolverInterface;
*/
class CommerceMulticurrencyResolver implements PriceResolverInterface {

/**
* The language manager.
*
* @var \Drupal\Core\Language\LanguageManagerInterface
*/
protected $languageManager;

/**
* Constructs a new CommerceMulticurrencyResolver object.
*
* @param \Drupal\Core\Language\LanguageManagerInterface $language_manager
* The language manager.
*/
public function __construct(LanguageManagerInterface $language_manager) {
Copy link
Copy Markdown

@vasike vasike Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on https://www.drupal.org/node/2831954#comment-11906059
and using the implementation suggested here, the tests won't work with $language_manager construct argument.

Please check my PR for the issue drupalcommerce/commerce#626
And maybe we could get the right solution for how this CommerceMulticurrencyResolver should be done

$this->languageManager = $language_manager;
}

/**
* {@inheritdoc}
*/
Expand All @@ -95,10 +112,10 @@ class CommerceMulticurrencyResolver implements PriceResolverInterface {
$currency_by_language = ['en' => 'USD', 'fr' => 'EUR', 'ja' => 'JPY'];

// Get current language.
$language = \Drupal::languageManager()->getCurrentLanguage()->getId();
$language = $this->languageManager->getCurrentLanguage()->getId();

// Get default language.
$default_language = \Drupal::languageManager()->getDefaultLanguage()->getId();
$default_language = $this->languageManager->getDefaultLanguage()->getId();

// Set default price to null. Default price will be used to return currency
// of default language if no currency has been found for current language.
Expand Down