Skip to content

Migrate GenerateSupportedTargetFrameworkAlias to IMultiThreadableTask #53954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimaTian wants to merge 3 commits into from
Closed

Migrate GenerateSupportedTargetFrameworkAlias to IMultiThreadableTask #53954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
603d864
Migrate GenerateSupportedTargetFrameworkAlias to IMultiThreadableTask
SimaTian Apr 17, 2026
c6cb5b9
Remove TaskEnvironment fallback from target framework alias task
SimaTian Apr 29, 2026
f6e5971
Delete tests, remove unnecessary interface on task
OvesN May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Tasks/Common/MetadataKeys.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ internal static class MetadataKeys

// Diagnostics
public const string DiagnosticCode = "DiagnosticCode";
public const string DisplayName = "DisplayName";
public const string Message = "Message";
public const string FilePath = "FilePath";
Comment thread
OvesN marked this conversation as resolved.
public const string Severity = "Severity";
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Microsoft.NET.Build.Tasks/GenerateSupportedTargetFrameworkAlias.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ protected override void ExecuteCore()
targetFrameworkAlias = $"{targetFrameworkAlias}-windows";
}

var displayName = string.IsNullOrWhiteSpace(tfm.GetMetadata("DisplayName")) ? targetFrameworkAlias : tfm.GetMetadata("DisplayName");
convertedTfms.Add(new TaskItem(targetFrameworkAlias, new Dictionary<string, string>() { { "DisplayName", displayName } }));
var displayName = string.IsNullOrWhiteSpace(tfm.GetMetadata(MetadataKeys.DisplayName)) ? targetFrameworkAlias : tfm.GetMetadata(MetadataKeys.DisplayName);
convertedTfms.Add(new TaskItem(targetFrameworkAlias, new Dictionary<string, string>() { { MetadataKeys.DisplayName, displayName } }));
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...Microsoft.NET.Build.Tasks.Tests/GivenThatWeWantToGenerateSupportedTargetFrameworkAlias.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void It_generates_supported_target_framework_alias_items_when_using_wpf_o

private void RunTask(string targetFrameworkMoniker, string targetPlatformMoniker, bool UseWpf, bool UseWindowsForms, List<(string, string)> expectedResult)
{
Func<List<(string, string)>, ITaskItem[]> convertToItems = (List<(string, string)> list) => list.Select(item => new TaskItem(item.Item1, new Dictionary<string, string>() { { "DisplayName", item.Item2 } })).ToArray();
Func<List<(string, string)>, ITaskItem[]> convertToItems = (List<(string, string)> list) => list.Select(item => new TaskItem(item.Item1, new Dictionary<string, string>() { { MetadataKeys.DisplayName, item.Item2 } })).ToArray();

var task = new GenerateSupportedTargetFrameworkAlias()
{
Expand Down
Loading