Skip to content

Migrate CreateWindowsSdkKnownFrameworkReferences to IMultiThreadableTask #53951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SimaTian wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Migrate CreateWindowsSdkKnownFrameworkReferences to IMultiThreadableTask #53951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23f1a68
Migrate CreateWindowsSdkKnownFrameworkReferences to IMultiThreadableTask
SimaTian Apr 17, 2026
3f8bd6a
Address review: fix nullable annotation (CS8632) and test assertions
SimaTian Apr 17, 2026
6ef54f4
Strengthen Windows SDK threading tests
SimaTian Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Tasks/Microsoft.NET.Build.Tasks/CreateWindowsSdkKnownFrameworkReferences.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ namespace Microsoft.NET.Build.Tasks
// Otherwise, create KnownFrameworkReference items based on WindowsSdkSupportedTargetPlatformVersion items, using WindowsSdkPackageVersion and MinimumNETVersion metadata

[MSBuildMultiThreadableTask]
public class CreateWindowsSdkKnownFrameworkReferences : TaskBase
public class CreateWindowsSdkKnownFrameworkReferences : TaskBase, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }

public bool UseWindowsSDKPreview { get; set; }

public string WindowsSdkPackageVersion { get; set; }
Expand Down Expand Up @@ -151,15 +153,15 @@ private static TaskItem CreateKnownFrameworkReference(string windowsSdkPackageVe
: $"Microsoft.Windows.SDK.NET.Ref.{profile}";

var knownFrameworkReference = new TaskItem(itemSpec);
knownFrameworkReference.SetMetadata("TargetFramework", $"net{targetFrameworkVersion}-windows{targetPlatformVersion}");
knownFrameworkReference.SetMetadata("RuntimeFrameworkName", "Microsoft.Windows.SDK.NET.Ref");
knownFrameworkReference.SetMetadata(MetadataKeys.TargetFramework, $"net{targetFrameworkVersion}-windows{targetPlatformVersion}");
knownFrameworkReference.SetMetadata(MetadataKeys.RuntimeFrameworkName, "Microsoft.Windows.SDK.NET.Ref");
knownFrameworkReference.SetMetadata("DefaultRuntimeFrameworkVersion", windowsSdkPackageVersion);
knownFrameworkReference.SetMetadata("LatestRuntimeFrameworkVersion", windowsSdkPackageVersion);
knownFrameworkReference.SetMetadata("TargetingPackName", "Microsoft.Windows.SDK.NET.Ref");
knownFrameworkReference.SetMetadata("TargetingPackVersion", windowsSdkPackageVersion);
knownFrameworkReference.SetMetadata("RuntimePackAlwaysCopyLocal", "true");
knownFrameworkReference.SetMetadata(MetadataKeys.RuntimePackAlwaysCopyLocal, "true");
knownFrameworkReference.SetMetadata("RuntimePackNamePatterns", "Microsoft.Windows.SDK.NET.Ref");
knownFrameworkReference.SetMetadata("RuntimePackRuntimeIdentifiers", "any");
knownFrameworkReference.SetMetadata(MetadataKeys.RuntimePackRuntimeIdentifiers, "any");
knownFrameworkReference.SetMetadata("IsWindowsOnly", "true");

if (!string.IsNullOrEmpty(profile))
Expand Down
Loading
Loading