Re-enable Microsoft.Extensions.Hosting FunctionalTests/TestApp shutdown coverage#128252
Draft
Copilot wants to merge 2 commits into
Draft
Re-enable Microsoft.Extensions.Hosting FunctionalTests/TestApp shutdown coverage#128252Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f2762648-8aaf-44cd-a0bb-269b2a6b371d Co-authored-by: rosebyte <14963300+rosebyte@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FunctionalTests/TestApp on Extensions Hosting
Re-enable Microsoft.Extensions.Hosting FunctionalTests/TestApp shutdown coverage
May 15, 2026
This was referenced May 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.Extensions.Hostingfunctional shutdown tests were effectively dead code: they were globally suppressed and pointed at an empty app path, so they never executed meaningful TestApp coverage.This updates the tests to use the in-repo TestApp again and removes the suppression that prevented them from running.
FunctionalTests/TestApp wiring
applicationPath = string.Emptypath with repository-root discovery logic fortests/TestApp.DeploymentParameters.ApplicationNametoMicrosoft.Extensions.Hosting.TestAppso deploy/run targets the correct published assembly.Re-enable test execution
IgnoreForCIfromMicrosoft.Extensions.Hosting.Functional.Tests.csproj.ActiveIssueassembly-level suppression fromFunctionalTests/Properties/AssemblyInfo.cs.Fixes #34090