Skip to content

[WIP] Add IServiceCollectionValidator for DI validation#128246

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/add-isc-collection-validator
Draft

[WIP] Add IServiceCollectionValidator for DI validation#128246
Copilot wants to merge 3 commits into
mainfrom
copilot/add-isc-collection-validator

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026 •
edited
Loading

  • Create ValidationResult readonly struct in Abstractions package
  • Create IServiceCollectionValidator interface in Abstractions package
  • Create ServiceCollectionValidationExtensions in Abstractions package (with generic, instance, and delegate overloads)
  • Integrate validator execution into BuildServiceProvider in main DI package
  • Add error message string resource to main DI package
  • Update Abstractions ref file with new public API surface
  • Add tests to ServiceProviderValidationTests.cs
  • Build verified - both libraries build cleanly
  • All 1380 tests pass (including 11 new validator tests)

Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 08:19
Copilot AI linked an issue May 15, 2026 that may be closed by this pull request
Add IServiceCollectionValidator for optional DI validation at BuildServiceProvider #119646
Open
@rosebyte
Add IServiceCollectionValidator for optional DI validation at BuildSe…
6e28c59 
…rviceProvider

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/7f9fbc0f-fc3d-49a0-827c-b36f71b15b48

Co-authored-by: rosebyte <14963300+rosebyte@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 08:56
Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 09:10
Copilot stopped work on behalf of rosebyte due to an error May 15, 2026 09:19
Copilot had to stop work due to a timeout.
Copilot AI requested a review from rosebyte May 15, 2026 09:19
tarekgh
tarekgh reviewed May 15, 2026
View reviewed changes
Comment thread src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ValidationResult.cs
/// <summary>
/// Represents the result of an <see cref="IServiceCollectionValidator"/> validation.
/// </summary>
public readonly struct ValidationResult
Copy link
Copy Markdown
Member

@tarekgh tarekgh May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to use the same type name ValidationResult which already used in the data annotations?

https://source.dot.net/#System.ComponentModel.Annotations/System/ComponentModel/DataAnnotations/ValidationResult.cs,15

@tarekgh tarekgh added this to the 11.0.0 milestone May 15, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service Bot commented May 15, 2026

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

This was referenced May 15, 2026
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarekgh tarekgh tarekgh left review comments

@rosebyte rosebyte Awaiting requested review from rosebyte

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@rosebyte rosebyte

Copilot code review Copilot

Labels

area-Extensions-DependencyInjection

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Add IServiceCollectionValidator for optional DI validation at BuildServiceProvider

3 participants

@tarekgh @rosebyte